Soft Patch Panel
 help / color / Atom feed
* [spp] [PATCH] spp_nfv: fix error of patch command
@ 2019-07-29  9:37 yasufum.o
  0 siblings, 0 replies; only message in thread
From: yasufum.o @ 2019-07-29  9:37 UTC (permalink / raw)
  To: spp, ferruh.yigit, yasufum.o

From: Yasufumi Ogawa <yasufum.o@gmail.com>

This patch is to fix for patching ports.

Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
---
 src/nfv/params.h          | 1 +
 src/spp-ctl/spp_webapi.py | 7 +++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/nfv/params.h b/src/nfv/params.h
index 06e6f1f..5850791 100644
--- a/src/nfv/params.h
+++ b/src/nfv/params.h
@@ -18,6 +18,7 @@ struct porttype_map portmap[] = {
 	{ .port_name = "vhost", .port_type = VHOST, },
 	{ .port_name = "pcap", .port_type = PCAP, },
 	{ .port_name = "nullpmd", .port_type = NULLPMD, },
+	{ .port_name = "tap", .port_type = TAP, },
 	{ .port_name = NULL,    .port_type = UNDEF, },
 };
 
diff --git a/src/spp-ctl/spp_webapi.py b/src/spp-ctl/spp_webapi.py
index 89b188a..25b2e6f 100644
--- a/src/spp-ctl/spp_webapi.py
+++ b/src/spp-ctl/spp_webapi.py
@@ -13,6 +13,9 @@ import sys
 
 import spp_proc
 
+PORT_TYPES = ["phy", "vhost", "ring", "pcap", "nullpmd", "tap"]
+VF_PORT_TYPES = ["phy", "vhost", "ring"]
+# TODO(yasufum) consider PCAP_PORT_TYPES is required.
 
 LOG = logging.getLogger(__name__)
 
@@ -50,7 +53,7 @@ class BaseHandler(bottle.Bottle):
     def _validate_port(self, port):
         try:
             if_type, if_num = port.split(":")
-            if if_type not in ["phy", "vhost", "ring", "pcap", "nullpmd"]:
+            if if_type not in PORT_TYPES:
                 raise
             int(if_num)
         except Exception:
@@ -176,7 +179,7 @@ class V1VFCommon(object):
         vf = {}
         vf["client-id"] = info["client-id"]
         vf["ports"] = []
-        for key in ["phy", "vhost", "ring"]:
+        for key in VF_PORT_TYPES:
             for idx in info[key]:
                 vf["ports"].append(key + ":" + str(idx))
         vf["master-lcore"] = info["master-lcore"]
-- 
2.17.1


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29  9:37 [spp] [PATCH] spp_nfv: fix error of patch command yasufum.o

Soft Patch Panel

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/spp/0 spp/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 spp spp/ http://inbox.dpdk.org/spp \
		spp@dpdk.org
	public-inbox-index spp


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.spp


AGPL code for this site: git clone https://public-inbox.org/ public-inbox