From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Subject: [spp] [PATCH 2/2] docs: rename SPP_CTRL_IP for sppc Date: Thu, 22 Aug 2019 17:28:06 +0900 Message-ID: <20190822082806.20327-3-yasufum.o@gmail.com> (raw) In-Reply-To: <20190822082806.20327-1-yasufum.o@gmail.com> From: Yasufumi Ogawa <yasufum.o@gmail.com> As `SPP_CTRL_IP` is renamed in app container scripts, this update is to rename it in documentation. Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com> --- docs/guides/tools/sppc/app_launcher.rst | 4 ++-- docs/guides/tools/sppc/getting_started.rst | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/guides/tools/sppc/app_launcher.rst b/docs/guides/tools/sppc/app_launcher.rst index 233553a..ae960c2 100644 --- a/docs/guides/tools/sppc/app_launcher.rst +++ b/docs/guides/tools/sppc/app_launcher.rst @@ -45,11 +45,11 @@ inside a container. Setup ----- -You should define ``SPP_CTRL_IP`` environment variable to SPP controller +You should define ``SPP_CTL_IP`` environment variable to SPP controller be accessed from other SPP processes inside containers. SPP controller is a CLI tool for accepting user's commands. -You cannot use ``127.0.0.1`` or ``localhost`` for ``SPP_CTRL_IP`` +You cannot use ``127.0.0.1`` or ``localhost`` for ``SPP_CTL_IP`` because SPP processes try to find SPP controller inside each of containers and fail to. From inside of the container, SPP processes should be known IP address diff --git a/docs/guides/tools/sppc/getting_started.rst b/docs/guides/tools/sppc/getting_started.rst index 4834cc0..e088661 100644 --- a/docs/guides/tools/sppc/getting_started.rst +++ b/docs/guides/tools/sppc/getting_started.rst @@ -135,14 +135,14 @@ Launch SPP and App Containers ----------------------------- Before launch containers, you should set IP address of host machine -as ``SPP_CTRL_IP`` environment variable +as ``SPP_CTL_IP`` environment variable for controller to be accessed from inside containers. It is better to define this variable in ``$HOME/.bashrc``. .. code-block:: console # Set your host IP address - export SPP_CTRL_IP=HOST_IPADDR + export SPP_CTL_IP=HOST_IPADDR SPP Controller @@ -180,7 +180,7 @@ processes. SPP Primary Container ~~~~~~~~~~~~~~~~~~~~~ -As ``SPP_CTRL_IP`` is activated, you are enalbed to run +As ``SPP_CTL_IP`` is activated, you are enalbed to run ``app/spp-primary.py`` with options of EAL and SPP primary in terminal 3. In this case, launch spp-primary in background mode using one core -- 2.17.1
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-22 8:28 [spp] [PATCH 0/2] Rename env variable SPP_CTRL_IP yasufum.o 2019-08-22 8:28 ` [spp] [PATCH 1/2] tools/sppc: change env var SPP_CTRL_IP yasufum.o 2019-08-22 8:28 ` yasufum.o [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190822082806.20327-3-yasufum.o@gmail.com \ --to=yasufum.o@gmail.com \ --cc=ferruh.yigit@intel.com \ --cc=spp@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Soft Patch Panel Archives are clonable: git clone --mirror http://inbox.dpdk.org/spp/0 spp/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 spp spp/ http://inbox.dpdk.org/spp \ spp@dpdk.org public-inbox-index spp Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.spp AGPL code for this site: git clone https://public-inbox.org/ public-inbox