From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2140A0613 for ; Tue, 27 Aug 2019 05:45:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFD361C023; Tue, 27 Aug 2019 05:45:40 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id A185B1C023 for ; Tue, 27 Aug 2019 05:45:38 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id h3so11058726pls.7 for ; Mon, 26 Aug 2019 20:45:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=UOyhLNgu5+f7jqRHROLeCtCTjO94OWqlJyhSbIeVAm8=; b=uRFi7C10D35j56akuMMBep1idTJu+y8s6k3fOVCl/jBoTSK9DZuxfHN2Wkoo29crLN r3zu2MW3l0NCWYw6WEHxylyypJaPxgn+by7m0GS0o2Ig/LSPyL+jm4DiKZLOz9EvTeMi paAqEsR0gNha7AwIK5WnW7dJXbN07Rf2gXu5oglOe8o4LzoNIY7zvm0XI6xAsJ/PbV0H hoGRmB0AFRKRX7qy7mZ8RLdw7CI/Icds6V6kttlHymGUCehpLt8xg6iQUPApWqes561E 9EKsSVvH6f8TzzJZgWBevu9XTtR9HWcuwoL/XvaWIFL467q4RG38GKMZKIHz1AE+hC5I bhzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=UOyhLNgu5+f7jqRHROLeCtCTjO94OWqlJyhSbIeVAm8=; b=WeOESMUSgLR4+YVr1Ug9xJORqLnu9Jlu8Jh07SrouXNOVN3ekC8oBhO+HegC8J4TME 7r4rFmNM+bIQ/tQf9dekg9w5k+qvozd/YB7hh3UWGYFGmMww4JtrJ/+/sbtgcuGTdcRc XEGRE0TMHAg42OxF/LW/+W2KuxzTkSFMoidIGLpXcde/Ca9i0RmwkByr2JMLV95Yi3Hm FwZAZ7vq/w2qQp/IMUdgKffvWnWcBjwcg94j95Qt3sBYbYwSfvl07loiTXCiXlP0PX+P V3BV+VP2rLkNJIwp7fzqLJgHlEOctqfGeB27a2obQR16va02M1aNesLCpRW41qkTPmid IIfg== X-Gm-Message-State: APjAAAXbAUg1zZ5DxKXQ8hPVr9jWXDxuo4SyxHyErONizktj77gzBcoD s8R+4VXiA4xIYAams5XM+0BapKELFMA= X-Google-Smtp-Source: APXvYqxe3d3c03ZkuFhjQQXwLUE/FbkbB41DvlOLlQitayE9hVOziYDFyF6b2CMA33zERQIH2mq3/w== X-Received: by 2002:a17:902:d717:: with SMTP id w23mr21622729ply.321.1566877537678; Mon, 26 Aug 2019 20:45:37 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id ev3sm1558167pjb.3.2019.08.26.20.45.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 20:45:37 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Tue, 27 Aug 2019 12:45:28 +0900 Message-Id: <20190827034528.5366-1-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [spp] [PATCH] spp_nfv: fix buffer overflow X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa String `port_set` is used for containing a set of src and dst ports for returned message. It is formatted as 39 chars as following, although its buffer size is 32. "{\"src\":\"%s:%d\",\"dst\":\"%s:%d\"}" // 39 chars This update is to fix the bug by increasing buffer size to 128 which is enough for the usage. Signed-off-by: Yasufumi Ogawa --- src/nfv/commands.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/nfv/commands.h b/src/nfv/commands.h index 6eda72f..499bdd4 100644 --- a/src/nfv/commands.h +++ b/src/nfv/commands.h @@ -141,7 +141,7 @@ parse_command(char *str) int max_token = 0; int ret = 0; char result[16] = { 0 }; /* succeeded or failed. */ - char port_set[32] = { 0 }; + char port_set[128] = { 0 }; char *p_type; int p_id; -- 2.17.1