From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6480DA2EEB for ; Thu, 12 Sep 2019 12:48:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C4F61E933; Thu, 12 Sep 2019 12:48:44 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 35C171E933 for ; Thu, 12 Sep 2019 12:48:43 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id h195so15763370pfe.5 for ; Thu, 12 Sep 2019 03:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=ycX0QuksklluoHgwYsjporUI6nAjjz6Htj30l4B2Unw=; b=FaOLA1E7XVY0xIJaaE9XhVpeTrQmPOVmBtoCIszbqMOuUASamEaNsQ+zfo8txbygNf gkBF2JlzLSpfBIff+uuLuEzi9/aVT0zh6Gpn6rrR3mB80q7ZYtYa6cKU+74mS2UwD/v/ +QgmGMYl3RdOVYLevr47xJtuocssiSbsg6Jt6FZ1ypjaFZcI2IXDM2+gakNuJGsL4IXW hfNXwsYbX/Kkf+Nyy0eDuKHEfkKySF4U0e/DxXpOghphqK1sfNRqIF6PVpU/h6Qx24E9 hiTfqdodmfxkxjvNxTfEi5lXpZJbrq4avf0pdDgGvsjvg6dvFW1i34C5V93N0LYxH6+b BlsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=ycX0QuksklluoHgwYsjporUI6nAjjz6Htj30l4B2Unw=; b=tHjIBejByDb7BKccTfh+W5VuLJ9R3cUqoFTrK740hfDp66b4ipVhUyn7uHBA4LOlPF V1jFVufNK9H7joILaiLyKBqvnd4ZHBVdTl/MvEaq/1P1SrVwpZ3DQztSpQLcUCvuT827 wRoqzbEJr6nv4j0psXgk13pi6ZSCED3MAXhN1doTxnHpsWwGWERCnqI7EzLQfzMmdHAm GtWlvEgycV7w4aqKnKb59TqISvvxnZLLSZTyBFpGqpPCEAHDCMpzSuw9wnRYQXEEkBJj ViW4UUCVmudpAsaxbnw/ONWf1Fzgaw0locJjn+K7QazoOnjwqfUVBBdlwW1B8zk4yW15 gtiA== X-Gm-Message-State: APjAAAUfhxxUjeaezL26ZBahjMNBTlcm3dAOCvfuVj+bcZogmG99EQhU CVsBMp88SdeJeEv+VQoXYczcYy5z X-Google-Smtp-Source: APXvYqxEvkL0Y33rXoCUCWya1by4/mHY8ksmc/sIsvR5vpsWisz9FrCTZMavw1D4K+zYDZlfVFRePw== X-Received: by 2002:a63:2b49:: with SMTP id r70mr12693095pgr.182.1568285322385; Thu, 12 Sep 2019 03:48:42 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id t3sm26034930pfe.7.2019.09.12.03.48.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2019 03:48:41 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Thu, 12 Sep 2019 19:48:24 +0900 Message-Id: <20190912104824.21519-10-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190912104824.21519-1-yasufum.o@gmail.com> References: <20190912104824.21519-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 9/9] shared: add TODO to fix bug in latency stats X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa Spp_vf and spp_mirror has a feature for measuring latency of ring PMD. This optional feature is intended to be used by developers and is not activate by default. It is activated by editing Makefile in src/vf and src/mirror. Although this feature is not interested by most of users and does not prevent users from using SPP, it should be fixed. This update is to add TODO comments for notifying users to not use this feature until the bug is fixed. Signed-off-by: Yasufumi Ogawa --- src/mirror/Makefile | 4 ++++ src/shared/secondary/spp_worker_th/latency_stats.c | 5 +++++ src/vf/Makefile | 4 ++++ 3 files changed, 13 insertions(+) diff --git a/src/mirror/Makefile b/src/mirror/Makefile index 0adab15..0bd079a 100644 --- a/src/mirror/Makefile +++ b/src/mirror/Makefile @@ -42,6 +42,10 @@ CFLAGS += -DSPP_MIRROR_SHALLOWCOPY # Optional Settings #CFLAGS += -DSPP_DEMONIZE + +# TODO(Hideyuki Yamashita) ringlatencystats cannot run because a fatal +# bug in initialization of this feature. So you should not use it until +# this fatal bug is fixed. #CFLAGS += -DSPP_RINGLATENCYSTATS_ENABLE ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) diff --git a/src/shared/secondary/spp_worker_th/latency_stats.c b/src/shared/secondary/spp_worker_th/latency_stats.c index 33b3b44..d43f6a8 100644 --- a/src/shared/secondary/spp_worker_th/latency_stats.c +++ b/src/shared/secondary/spp_worker_th/latency_stats.c @@ -48,6 +48,11 @@ cycles_per_ns(void) return rte_get_timer_hz() / NS_PER_SEC; } +/** + * TODO(Hideyuki Yamashita) This function has a fatal bug in rte_zmalloc() + * for `g_stats_info` and should be fixed. rte_zmalloc() returns NULL for + * unknow reason. + */ int sppwk_init_ring_latency_stats(uint64_t samp_intvl, uint16_t stats_count) { diff --git a/src/vf/Makefile b/src/vf/Makefile index 742986c..43e5e4d 100644 --- a/src/vf/Makefile +++ b/src/vf/Makefile @@ -37,6 +37,10 @@ CFLAGS += -DSPP_VF_MODULE # Optional Settings #CFLAGS += -DSPP_DEMONIZE + +# TODO(Hideyuki Yamashita) ringlatencystats cannot run because a fatal +# bug in initialization of this feature. So you should not use it until +# this fatal bug is fixed. #CFLAGS += -DSPP_RINGLATENCYSTATS_ENABLE ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),y) -- 2.17.1