From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36F64A2EEB for ; Thu, 12 Sep 2019 12:48:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B6962C19; Thu, 12 Sep 2019 12:48:40 +0200 (CEST) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by dpdk.org (Postfix) with ESMTP id 109872C19 for ; Thu, 12 Sep 2019 12:48:39 +0200 (CEST) Received: by mail-pf1-f170.google.com with SMTP id b13so15734431pfo.8 for ; Thu, 12 Sep 2019 03:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=8odybMPN6VqVFeLelOHasqCJI/bCYbO/b17mnoLtlak=; b=EcVGHA9qTMrgeaVLouFwGJn8b8vN99inYgxfxB+Wnr1yTJyqaKCQMh3I9EMv8zYta6 EZIFS4oS6HNvAKJLyekE7l1YguA/F4yaCUr5On/0Yy6aZYfzkdIciU/UOcb/xXlAuysG q7dFSG2w8Te/n4piA1iXHUg+KKery1jh7ZrAWXijefI+RCk5a+M4FuLncGOH0cTPA7QM qXIudvxqsM1GJNQluMvfsw4meB5BSeIQ7HyO94txgBq8ew8UvukRuM50gaca24FhCQA9 7T0CDXjhrfn6IoUpVvQnBA5h0d9wKli2IWg64JwiJsip3qk/OBxzTnWdHk4qcE7gLUNt s5mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=8odybMPN6VqVFeLelOHasqCJI/bCYbO/b17mnoLtlak=; b=tqrtnfoyCggBPXIaMubdZvLJ08eE3ZBsVB1hACjWmQ51KBgHTLb+3uokixb4EBOVMi RuDkpWasPi17XTNyRE1Mkzl4GagtDBNRyQ1mBcN5bGp45Q1ZBxNDfR0SlOThFe+kdDeZ P+Avs50uwBoamPlE9lg73PTNb/LzPDEGXrQMbzVUXmT6txs9eOacVSVPLJSs34y3LPAc Pp6NximbNxjEjcpCfHiqetPn3Ja8v1yXisrepnXicAa0dwyz3Yv0qQPg8KQavklnipaI ebrGRfGWHL7FFTPDlriNurjNmGJgQ3gXP4839zzFKnKPWdhZAI6UaoVf1cQYqagXbcKE 3pGQ== X-Gm-Message-State: APjAAAVPZYfOnhAHG6fWuDWlaCuzBeOs1Y0ByVuswUKwI+mNImCiSSsU XmGgpVQNMnd1MISHO8fUS0RmEpsN X-Google-Smtp-Source: APXvYqzBXIcUUCum2pz8ea3FEOudyd1pIkbOfR8t5L88sx3w118qksqkXnR0skT3wzKZYDlKsWteNQ== X-Received: by 2002:a17:90a:30e8:: with SMTP id h95mr11076393pjb.44.1568285318156; Thu, 12 Sep 2019 03:48:38 -0700 (PDT) Received: from localhost.localdomain ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id t3sm26034930pfe.7.2019.09.12.03.48.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Sep 2019 03:48:37 -0700 (PDT) From: yasufum.o@gmail.com To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Thu, 12 Sep 2019 19:48:21 +0900 Message-Id: <20190912104824.21519-7-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190912104824.21519-1-yasufum.o@gmail.com> References: <20190912104824.21519-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 6/9] spp_vf: revise util func for status command X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" From: Yasufumi Ogawa Util function spp_iterate_core_info() is for gettng each of lcore info for composing response of status command. This update is to rename it to iterate_lcore_info() and add comments as refactoring. Signed-off-by: Yasufumi Ogawa --- src/vf/vf_cmd_runner.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/src/vf/vf_cmd_runner.c b/src/vf/vf_cmd_runner.c index c94288a..305c4a2 100644 --- a/src/vf/vf_cmd_runner.c +++ b/src/vf/vf_cmd_runner.c @@ -428,9 +428,9 @@ exec_one_cmd(const struct sppwk_cmd_attrs *cmd) return ret; } -/* Iterate core information to create response to status command */ +/* Iterate core info to create response of spp_vf status */ static int -spp_iterate_core_info(struct sppwk_lcore_params *params) +iterate_lcore_info(struct sppwk_lcore_params *params) { int ret; int lcore_id, cnt; @@ -444,16 +444,12 @@ spp_iterate_core_info(struct sppwk_lcore_params *params) core = get_core_info(lcore_id); if (core->num == 0) { - ret = (*params->lcore_proc)( - params, lcore_id, - "", SPPWK_TYPE_NONE_STR, - 0, NULL, 0, NULL); + ret = (*params->lcore_proc)(params, lcore_id, "", + SPPWK_TYPE_NONE_STR, 0, NULL, 0, NULL); if (unlikely(ret != 0)) { RTE_LOG(ERR, VF_CMD_RUNNER, - "Cannot iterate core " - "information. " - "(core = %d, type = %d)\n", - lcore_id, SPPWK_TYPE_NONE); + "Failed to proc on lcore %d\n", + lcore_id); return SPPWK_RET_NG; } continue; @@ -474,9 +470,8 @@ spp_iterate_core_info(struct sppwk_lcore_params *params) if (unlikely(ret != 0)) { RTE_LOG(ERR, VF_CMD_RUNNER, - "Cannot iterate core " - "information. " - "(core = %d, type = %d)\n", + "Failed to get on lcore %d ," + "type %d\n", lcore_id, comp_info->wk_type); return SPPWK_RET_NG; } @@ -502,7 +497,7 @@ add_core(const char *name, char **output, lcore_params.output = tmp_buff; lcore_params.lcore_proc = append_core_element_value; - ret = spp_iterate_core_info(&lcore_params); + ret = iterate_lcore_info(&lcore_params); if (unlikely(ret != SPPWK_RET_OK)) { spp_strbuf_free(lcore_params.output); return SPPWK_RET_NG; -- 2.17.1