From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49CF6A04F0 for ; Thu, 19 Dec 2019 03:38:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E9845F90; Thu, 19 Dec 2019 03:38:56 +0100 (CET) Received: from dish-sg.nttdocomo.co.jp (dish-sg.nttdocomo.co.jp [202.19.227.74]) by dpdk.org (Postfix) with ESMTP id 9ABD5F90 for ; Thu, 19 Dec 2019 03:38:54 +0100 (CET) X-dD-Source: Outbound Received: from zssg-mailmd105.ddreams.local (zssg-mailmd900.ddreams.local [10.160.172.63]) by zssg-mailou102.ddreams.local (Postfix) with ESMTP id 10BAF120146; Thu, 19 Dec 2019 11:38:53 +0900 (JST) Received: from t131sg-mailcc11.ddreams.local (t131sg-mailcc11.ddreams.local [100.66.31.86]) by zssg-mailmd105.ddreams.local (dDREAMS) with ESMTP id <0Q2Q00YYRNCS1830@dDREAMS>; Thu, 19 Dec 2019 11:38:52 +0900 (JST) Received: from t131sg-mailcc11 (localhost [127.0.0.1]) by t131sg-mailcc11.ddreams.local (unknown) with SMTP id xBJ2cpWZ033139; Thu, 19 Dec 2019 11:38:51 +0900 Received: from zssg-mailmf104.ddreams.local (unknown [127.0.0.1]) by zssg-mailmf104.ddreams.local (Postfix) with ESMTP id 23C037E6038; Thu, 19 Dec 2019 11:38:37 +0900 (JST) Received: from zssg-mailmf104.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 221BE8E6062; Thu, 19 Dec 2019 11:38:37 +0900 (JST) Received: from localhost (unknown [127.0.0.1]) by IMSVA (Postfix) with SMTP id 1EE308E605E; Thu, 19 Dec 2019 11:38:37 +0900 (JST) X-IMSS-HAND-OFF-DIRECTIVE: localhost:10026 Received: from zssg-mailmf104.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB6328E605D; Thu, 19 Dec 2019 11:38:36 +0900 (JST) Received: from zssg-mailua106.ddreams.local (unknown [10.160.172.62]) by zssg-mailmf104.ddreams.local (Postfix) with ESMTP; Thu, 19 Dec 2019 11:38:36 +0900 (JST) Received: from [10.87.198.18] (unknown [10.160.183.129]) by zssg-mailua106.ddreams.local (dDREAMS) with ESMTPA id <0Q2Q00O38NC4PY60@dDREAMS>; Thu, 19 Dec 2019 11:38:28 +0900 (JST) Date: Thu, 19 Dec 2019 11:38:29 +0900 From: Hideyuki Yamashita In-reply-to: <040f1b8c-b143-9de2-ce04-c4886ac4fb1e@gmail.com> References: <20191218110021.303B.17218CA3@ntt-tx.co.jp_1> <040f1b8c-b143-9de2-ce04-c4886ac4fb1e@gmail.com> Message-id: <20191219113829.ACA2.17218CA3@ntt-tx.co.jp_1> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Becky! ver. 2.74.02 [ja] X-TM-AS-GCONF: 00 To: Yasufumi Ogawa Cc: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com, spp@dpdk.org Subject: Re: [spp] [spp 04700] Re: [PATCH 0/2] support of RPM install on CentOS X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Hi Yasufumi, Please see inline. > On 2019/12/18 11:00, Hideyuki Yamashita wrote: > > Hi Yasufumi, > > > > You are correct. > > Patch set is intened to update v18.08.4 branch not master. > > I appologize to confuse. > > > > If I have to update patch set itself with reagrd to the targeting > > version, please let me know. > > > > Thanks in advance. > LGTM, but I have a question and a comment. > > What do you think to provide rpm for the latest SPP? If I have a chance to test SPP on latest DPDK and if some updates needed then I will request changes on master. > > docs: add RPM installation for DPDK and SPP > It is more appropriate to use another label instead of 'docs' because your spec file is not included in docs. I'd like to suggest you to use the name of directory 'rpmbuild' simply. If you agree, I'd change the label while applying the change. No problem about your changing label on patchset (spec file). Thanks! BR, HIdeyuki Yamashita NTT TechnoCross > Thanks, > Yasufumi > > > > BR, > > Hideyui Yamashita > > NTT TechnoCross > > > >> Hi Hideyuki, > >> > >> I'm not sure the version of SPP because this update looks describing for v18.08.4 while the latest SPP is 19.08. Are you targeting not the master branch but v18.08.4 branch? > >> > >> Yasufumi > >> > >> On 2019/12/16 18:17, x-fn-spp@sl.ntt-tx.co.jp wrote: > >>> From: Hideyuki Yamashita > >>> > >>> So far installation of SPP is done by making source code. > >>> It is convenient for some users to install SPP using RPM. > >>> This patch set provides spec file of SPP to generate RPM of SPP. > >>> RST document is also updated to support this type of installation. > >>> > >>> Hideyuki Yamashita (2): > >>> docs: add RPM installation for DPDK and SPP > >>> docs: introduce RPM package support > >>> > >>> docs/guides/gsg/install.rst | 307 +++++++++++++++++++++++++++++++++++- > >>> rpmbuild/SPECS/spp.spec | 222 ++++++++++++++++++++++++++ > >>> 2 files changed, 521 insertions(+), 8 deletions(-) > >>> create mode 100644 rpmbuild/SPECS/spp.spec > >>> > > > > > >