From: Yasufumi Ogawa <yasufum.o@gmail.com>
To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com
Subject: [spp] [PATCH 5/7] cli: fix terminated if spp_primary is not running
Date: Thu, 16 Jan 2020 21:02:33 +0900 [thread overview]
Message-ID: <20200116120235.31550-6-yasufum.o@gmail.com> (raw)
In-Reply-To: <20200116120235.31550-1-yasufum.o@gmail.com>
If there is no spp_primary is running, SPP CLI is terminated when it
requests something to spp-ctl. This update is to fix the issue.
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
---
src/cli/commands/pri.py | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/src/cli/commands/pri.py b/src/cli/commands/pri.py
index f7d86bb..b39f911 100644
--- a/src/cli/commands/pri.py
+++ b/src/cli/commands/pri.py
@@ -77,7 +77,17 @@ class SppPrimary(object):
# Get status here for inspecting if forwarder exists. Do not run
# command such as `add` or `del` if forwarder does not exist.
res = self.spp_ctl_cli.get('primary/status')
- status = res.json()
+
+ # Check if spp_primary is running.
+ error_codes = self.spp_ctl_cli.rest_common_error_codes
+ if res.status_code in error_codes:
+ if res.status_code == 404:
+ print('No spp_primary is running.')
+ else:
+ print('Error: spp_primary is not running normaly.')
+ return None
+ else:
+ status = res.json()
if subcmd == 'status':
if res is not None:
--
2.17.1
next prev parent reply other threads:[~2020-01-16 12:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 12:02 [spp] [PATCH 0/7] Update for fixing errors for CLI Yasufumi Ogawa
2020-01-16 12:02 ` [spp] [PATCH 1/7] shared: revise vdev prefixs of pcap and nullpmd Yasufumi Ogawa
2020-01-16 12:02 ` [spp] [PATCH 2/7] shared: fix wrong port_type in parsing dev name Yasufumi Ogawa
2020-01-16 12:02 ` [spp] [PATCH 3/7] cli: add filter for running pri commands Yasufumi Ogawa
2020-01-16 12:02 ` [spp] [PATCH 4/7] cli: fix error in asking ports if no pri forwarder Yasufumi Ogawa
2020-01-16 12:02 ` Yasufumi Ogawa [this message]
2020-01-16 12:02 ` [spp] [PATCH 6/7] cli: move logfile to under project log dir Yasufumi Ogawa
2020-01-16 12:02 ` [spp] [PATCH 7/7] cli: fix parsing forward and stop commands Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116120235.31550-6-yasufum.o@gmail.com \
--to=yasufum.o@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).