From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3009EA0352 for ; Thu, 16 Jan 2020 13:02:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28AA31C2A4; Thu, 16 Jan 2020 13:02:54 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by dpdk.org (Postfix) with ESMTP id AEEF81C227 for ; Thu, 16 Jan 2020 13:02:52 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id p14so10126243pfn.4 for ; Thu, 16 Jan 2020 04:02:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=CcW2AUZ9tRYAlXw783QMYgeLzDSQ3jC+6x4X8vbkiho=; b=qb/CwwgxGFsTWyaHTqzilsC6VhpcBaH1JavKmn6gyXNcr95Dr45NLJrgf/wisA7l+8 DYdwMtwOQjCmJkvvamyOMbbsx3Q5i1LH3xgxup1ZZmlV72xZ1RqiZk+wdzzTNBGjKxqu NupUV3FC23/44TRSg1xq6QyHLsvdDDbBleNPvYMk2XSUxnTvU2H8xDmk8TSynwsspO6h WvwgAbKaNnCAzO+6BILg7h+pHAY6m5TKcWREsU3VQeoM90Go5uDZg2eznrOWNSipE8uz 8T9kRG0lQS6onsUR/WsG9zFdarfanL+THAOvI8LnkteIYUzSANP4QNJg5+/l6YzX09yG kQSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=CcW2AUZ9tRYAlXw783QMYgeLzDSQ3jC+6x4X8vbkiho=; b=tSCthqfxMU7zcZVLQnOTzPByYswJnu8LSCbRLgljeRq9i9buheDSgvezylFBDNzXeI 03oF/1i2cLG3WErUvgCJGnc33OWeA2yKLd2dmWPOP4WYUwjAdUL8PtRVWejCPrDOHnIb quHawN4Eglt8mVgfENYpz+AWuQLBXz5SC92valopHagWUQc11CFyYBBquWowB1V+fF1q sGqHLi0MmrfFay+UY7mh+gtrCbi7TrxXW7Xh9NTlWQnKPXubzU3zS9ardX+P8l4O58E+ xVICQxPFi++/QVgUURWYS/OvdrzAB7ZrOd4CmPRejXtZVwJ0YUABcQBoLQDRZZcYo6f7 Hw7Q== X-Gm-Message-State: APjAAAUjNUpECiq91J0vl1OsML4JUk+y2ReM7cYd3gU2zEdRRwmiP3F1 tFdZA1YPJJ7rjCK/a1qoLtt8DS+C X-Google-Smtp-Source: APXvYqyfsjEJzNnJXvvlmdGR3Vng+q+oufwXmiSCfcEFEhK+uhK1H20xLBqdLmCbQgyWShfsrkP/9A== X-Received: by 2002:aa7:8f33:: with SMTP id y19mr35690812pfr.47.1579176171815; Thu, 16 Jan 2020 04:02:51 -0800 (PST) Received: from localhost.localdomain ([2400:4050:c8c2:de00:98b6:858d:e282:492e]) by smtp.gmail.com with ESMTPSA id u7sm25392890pfh.128.2020.01.16.04.02.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 04:02:51 -0800 (PST) From: Yasufumi Ogawa To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Thu, 16 Jan 2020 21:02:35 +0900 Message-Id: <20200116120235.31550-8-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200116120235.31550-1-yasufum.o@gmail.com> References: <20200116120235.31550-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 7/7] cli: fix parsing forward and stop commands X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" This update is to fix a bug in which _run_forward_or_stop() expects a str type argument, but passed a list. Fixes: 17c6d451fa60 ("cli: add filter for running pri commands") Signed-off-by: Yasufumi Ogawa --- src/cli/commands/pri.py | 6 +++--- src/cli/spp_ctl_client.py | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/cli/commands/pri.py b/src/cli/commands/pri.py index b39f911..a13137d 100644 --- a/src/cli/commands/pri.py +++ b/src/cli/commands/pri.py @@ -105,9 +105,9 @@ class SppPrimary(object): elif subcmd == 'del': self._do_if_forwarder_exists(status, self._run_del, params) - elif subcmd == 'forward' or cmd == 'stop': + elif subcmd == 'forward' or subcmd == 'stop': self._do_if_forwarder_exists(status, - self._run_forward_or_stop, params) + self._run_forward_or_stop, subcmd) elif subcmd == 'patch': self._do_if_forwarder_exists(status, self._run_patch, params) @@ -818,7 +818,7 @@ class SppPrimary(object): elif cmd == 'stop': req_params = {'action': 'stop'} else: - print('Unknown command. "forward" or "stop"?') + print('Unknown command {}. "forward" or "stop"?'.format(cmd)) res = self.spp_ctl_cli.put('primary/forward', req_params) diff --git a/src/cli/spp_ctl_client.py b/src/cli/spp_ctl_client.py index 7418353..7b366b2 100644 --- a/src/cli/spp_ctl_client.py +++ b/src/cli/spp_ctl_client.py @@ -31,10 +31,10 @@ class SppCtlClient(object): # for spp.py. if res.status_code == 400: logger.info('Syntax or lexical error, or SPP ' - 'returns error for the request.') + 'returns error for the request.') elif res.status_code == 404: logger.info('URL is not supported, or no SPP ' - 'process of client-id in a URL.') + 'process of client-id in a URL.') elif res.status_code == 500: logger.info('System error occured in spp-ctl.') -- 2.17.1