From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6388DA0542 for ; Thu, 13 Feb 2020 13:10:44 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0E2F91BFCF; Thu, 13 Feb 2020 13:10:44 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by dpdk.org (Postfix) with ESMTP id 5E6C41BFA2 for ; Thu, 13 Feb 2020 13:10:42 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id 185so2997212pfv.3 for ; Thu, 13 Feb 2020 04:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=P7YyuvPrx1Z9IMcnsNdFqmWSut9HpYG65kS7ZwztcQw=; b=Ob1oYnc6VOXkDviWAp62v0AkaIlU1JDhrfwdfUQFTlPQ0x0TiQDlPVfWzIt1iJ9efC 0xjtYKvmXrbnnOXhG/t29XtQMrhTbTZ6a1aQfjPq5zVdVkoRMKCMbiJ+NhP7hqiAxmvh mcv1CoVkV/QpQM1ZSjmZM2ATy3o1jhTDtbjXYHidYqysahxKPjWQ2CwTrNmXlD5XHdWk +tB0uYqvo2HpfsCR+hSqxEqDGcc+A58Nq/c74EZIIjdDHALjKuOp7tP2yoN+kB79iVOs zmePIF4edlELy+Hl7VRP9AJMNRDlYPJ1wwB8265CJmkg8CbeOoZNtAPrj2SrQyoJE1LB 8wVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=P7YyuvPrx1Z9IMcnsNdFqmWSut9HpYG65kS7ZwztcQw=; b=GujcGeyUB7L+eqpir2+3OmHCJVFVDbfPje0yOmOOQhjeKmcl1UJjre8+ant7pZcz6u 8vjdOjmoDJR6PzekLifRFMS/OC4wKDErUbW9MiNuh/jKTqZmRDKdGNiCYMXkhPMVUUoQ Vd3sS9D3RaFQqvvdXoamLXBeeCCf9glqsWpYxUuJ2AERF9pA7dPySIGsNtyOAy3AHm2n /yqycx/eSxrvPlWaOMnXLV/j4wVAOM/8pUadlYtN2kK+Vu4kZ3pCqn7cDlT45Sqf7Ht3 yfL4FaIW4IJrbqPMaqBePHJle3UXUFJ/cECnfxQJPlyr/aUteCXH0IY+0h5qTd8o1oQQ r0ZQ== X-Gm-Message-State: APjAAAUSmWqAbS5e9uj42s1Bw8z6zGC6niAwtmdzaS00V45EhdrLmz6+ /hDokv9ix9gAR8mZjTcousAgUV7i X-Google-Smtp-Source: APXvYqwRgKI1Z4V2slEJx+Ig3YHgSpVtkuQNDqOI0QFRw7SH4z0TYva1McqFK8czKXdCCGrcXloSCw== X-Received: by 2002:a63:fe4f:: with SMTP id x15mr6600816pgj.30.1581595840988; Thu, 13 Feb 2020 04:10:40 -0800 (PST) Received: from localhost.localdomain ([2400:4050:c8c2:de00:c476:8ede:b61b:c7f6]) by smtp.gmail.com with ESMTPSA id v8sm2862476pff.151.2020.02.13.04.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 04:10:40 -0800 (PST) From: Yasufumi Ogawa To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Thu, 13 Feb 2020 21:10:26 +0900 Message-Id: <20200213121029.27702-3-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200213121029.27702-1-yasufum.o@gmail.com> References: <20200213121029.27702-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 2/5] tools/sppc: check mandatory params for suricata X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Suricata container app is failed if no dev ID is given because of accessing None object. This update is to add checking this parameter. Signed-off-by: Yasufumi Ogawa --- tools/sppc/app/suricata.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/sppc/app/suricata.py b/tools/sppc/app/suricata.py index f206036..ad4e053 100755 --- a/tools/sppc/app/suricata.py +++ b/tools/sppc/app/suricata.py @@ -29,6 +29,10 @@ def parse_args(): def main(): args = parse_args() + # Check for other mandatory opitons. + if args.dev_ids is None: + common.error_exit('--dev-ids') + # Setup for vhost devices with given device IDs. dev_ids_list = app_helper.dev_ids_to_list(args.dev_ids) sock_files = app_helper.sock_files(dev_ids_list) -- 2.17.1