Soft Patch Panel
 help / color / Atom feed
* [spp] [PATCH] spp-ctl: fix exception when receiving large data
@ 2020-02-14  9:18 x-fn-spp-ml
  2020-02-18  7:41 ` Yasufumi Ogawa
  0 siblings, 1 reply; 2+ messages in thread
From: x-fn-spp-ml @ 2020-02-14  9:18 UTC (permalink / raw)
  To: ferruh.yigit, yasufum.o; +Cc: spp

From: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>

Upon receiving large size response, spp-ctl tries
to refer self variable which does not exist
and thus exception takes place.
This patch tries to refer Class Object instead.

Fixes: f747dcf8 ("spp-ctl: add updating for no existing sec procs")

Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
---
 src/spp-ctl/spp_ctl.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/spp-ctl/spp_ctl.py b/src/spp-ctl/spp_ctl.py
index ea19aa6..9e11097 100644
--- a/src/spp-ctl/spp_ctl.py
+++ b/src/spp-ctl/spp_ctl.py
@@ -124,7 +124,7 @@ class Controller(object):
             data = conn.recv(MSG_SIZE)
             if data and len(data) == MSG_SIZE:
                 # could not receive data at once. recieve remining data.
-                data += self._continue_recv(conn)
+                data += Controller._continue_recv(conn)
             if data:
                 data = data.decode()
         except Exception as e:
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [spp] [PATCH] spp-ctl: fix exception when receiving large data
  2020-02-14  9:18 [spp] [PATCH] spp-ctl: fix exception when receiving large data x-fn-spp-ml
@ 2020-02-18  7:41 ` Yasufumi Ogawa
  0 siblings, 0 replies; 2+ messages in thread
From: Yasufumi Ogawa @ 2020-02-18  7:41 UTC (permalink / raw)
  To: x-fn-spp-ml; +Cc: ferruh.yigit, spp

> From: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
> 
> Upon receiving large size response, spp-ctl tries
> to refer self variable which does not exist
> and thus exception takes place.
> This patch tries to refer Class Object instead.
> 
> Fixes: f747dcf8 ("spp-ctl: add updating for no existing sec procs")
Applied, thanks.

> 
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
> Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
> ---
>   src/spp-ctl/spp_ctl.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/spp-ctl/spp_ctl.py b/src/spp-ctl/spp_ctl.py
> index ea19aa6..9e11097 100644
> --- a/src/spp-ctl/spp_ctl.py
> +++ b/src/spp-ctl/spp_ctl.py
> @@ -124,7 +124,7 @@ class Controller(object):
>               data = conn.recv(MSG_SIZE)
>               if data and len(data) == MSG_SIZE:
>                   # could not receive data at once. recieve remining data.
> -                data += self._continue_recv(conn)
> +                data += Controller._continue_recv(conn)
>               if data:
>                   data = data.decode()
>           except Exception as e:
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-14  9:18 [spp] [PATCH] spp-ctl: fix exception when receiving large data x-fn-spp-ml
2020-02-18  7:41 ` Yasufumi Ogawa

Soft Patch Panel

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/spp/0 spp/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 spp spp/ http://inbox.dpdk.org/spp \
		spp@dpdk.org
	public-inbox-index spp


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.spp


AGPL code for this site: git clone https://public-inbox.org/ public-inbox