From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55AF9A0524 for ; Tue, 25 Feb 2020 11:35:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4FAC41BC24; Tue, 25 Feb 2020 11:35:09 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by dpdk.org (Postfix) with ESMTP id 9F6141BFCD for ; Tue, 25 Feb 2020 11:35:08 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id d6so6686105pgn.5 for ; Tue, 25 Feb 2020 02:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=WMRnN/v4rnm9+n4Q+601rk15FOO/NYmnyoKhboIUMkM=; b=hIeS3q5q+19YqBUFdYDaiB3UNBumg7nRxUSBAEuCl3aM9dGAibGjGli5WMtFbLgeme ngYfHpqmxykbthrNvaPJOXIeIllBCcnnz0vz9Y2qLwu9mOKouyJUBmy9Rpfup5DgPko0 oSp9Y2tv/9dZSvss5kwDGQl7bwAlCyo6sDXteJK7+M+aCNSadMIeBZ5few1xDAK5bzGe BDQMCTsATx4gM0lJiFSQ2zTD+N5zhKykI7t6MJrWaFFjLEybHdanXkMHr2N8akgqvKnF 6usXqzhTMyGT15QLZGILXflDh8efaoRFm2EOhFx/j6Sad5QU7NOZgLB9rZ71GlyKm0I/ ba7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=WMRnN/v4rnm9+n4Q+601rk15FOO/NYmnyoKhboIUMkM=; b=Ug/VrXdyVQTjUVXHLJYQTMCNC97KBxeKR+6aNMJiftTUPzEO7NEO4Gtv9/zF7OHEuI NYCiiYcZ8WFatYh2s4w/AzKMsX/k7iMYpP5aViKngvI+MZ9wSq0vqGcEfzJj+1FKFRCR jynJeK+iNHD1HrpkdXML2T9gIfc5ASkZqSEM9MOJOqYVBCk708jVdAA6U5vsC+eVrKzT c2m63DhQ5+Lc0I9CwFit1yal2IeBvJAcShii4+aOnDKEMgsggL6vrmPLsfKmMnMynZrH 4wZHcbzZvVe+mClfjlgfxBjNRGkrnn/cM3jd6Vm010anRQpZkD6jAPWnDQ/LnO7tXC3T ABSA== X-Gm-Message-State: APjAAAXw1RhFooCGTsM+eEjsOH8ZDR6u0bkA83OPRN7z86Yxu+77SnJ7 w+CwRGnsBhFhkzuBsGjsmzctMhaO X-Google-Smtp-Source: APXvYqwyTNT4QH1XHxwKwiFk/er0r1fgppP9jQtVJymmvRTg3REwhJ2h50ouwjzmzC4mUNMsH8fBpQ== X-Received: by 2002:a63:dc02:: with SMTP id s2mr34140588pgg.400.1582626907622; Tue, 25 Feb 2020 02:35:07 -0800 (PST) Received: from localhost.localdomain ([2400:4050:c8c2:de00:35bc:b9a3:f404:3cf2]) by smtp.gmail.com with ESMTPSA id a10sm15819987pgk.71.2020.02.25.02.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 02:35:07 -0800 (PST) From: Yasufumi Ogawa To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Tue, 25 Feb 2020 19:34:26 +0900 Message-Id: <20200225103446.8243-10-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200225103446.8243-1-yasufum.o@gmail.com> References: <20200225103446.8243-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 09/29] tools/sppc: update dev options of load-balancer X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Update options for vdevs of load-balancer container app. Signed-off-by: Yasufumi Ogawa --- tools/sppc/app/load-balancer.py | 51 +++++++++++++++++---------------- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/tools/sppc/app/load-balancer.py b/tools/sppc/app/load-balancer.py index 687bfe5..d86a04b 100755 --- a/tools/sppc/app/load-balancer.py +++ b/tools/sppc/app/load-balancer.py @@ -31,7 +31,7 @@ def parse_args(): type=str, help="List of tx ports and queues handled by the I/O tx lcores") parser.add_argument( - '-w', '--worker-lcores', + '-wl', '--worker-lcores', type=str, help="List of worker lcores") parser.add_argument( @@ -58,6 +58,8 @@ def parse_args(): def main(): args = parse_args() + app_name = 'load_balancer' + # Container image name such as 'sppc/dpdk-ubuntu:18.04' if args.container_image is not None: container_image = args.container_image @@ -66,27 +68,33 @@ def main(): common.IMG_BASE_NAMES['dpdk'], args.dist_name, args.dist_ver) - # Check for other mandatory opitons. - if args.dev_ids is None: - common.error_exit('--dev-ids') + # Setup devices with given device UIDs. + dev_uids = None + sock_files = None + if args.dev_uids is not None: + if app_helper.is_valid_dev_uids(args.dev_uids) is False: + print('Invalid option: {}'.format(args.dev_uids)) + exit() - # Setup for vhost devices with given device IDs. - dev_ids_list = app_helper.dev_ids_to_list(args.dev_ids) - sock_files = app_helper.sock_files(dev_ids_list) + dev_uids_list = args.dev_uids.split(',') + sock_files = app_helper.sock_files(dev_uids_list) # Setup docker command. docker_cmd = ['sudo', 'docker', 'run', '\\'] docker_opts = app_helper.setup_docker_opts( args, container_image, sock_files) - app_name = 'load_balancer' - cmd_path = '%s/examples/%s/%s/%s' % ( - env.RTE_SDK, app_name, env.RTE_TARGET, app_name) + cmd_path = '{0:s}/examples/{1:s}/{2:s}/{1:s}'.format( + env.RTE_SDK, app_name, env.RTE_TARGET) # Setup testpmd command. lb_cmd = [cmd_path, '\\'] - file_prefix = 'spp-lb-container%d' % dev_ids_list[0] + # Setup EAL options. + if args.name is not None: + file_prefix = app_helper.gen_sppc_file_prefix(args.name) + else: + file_prefix = app_helper.gen_sppc_file_prefix(app_name) eal_opts = app_helper.setup_eal_opts(args, file_prefix) lb_opts = [] @@ -95,37 +103,30 @@ def main(): if args.rx_ports is None: common.error_exit('--rx-ports') else: - rx_ports = '"%s"' % args.rx_ports - lb_opts += ['--rx', rx_ports, '\\'] + lb_opts += ['--rx', '"{:s}"'.format(args.rx_ports), '\\'] if args.tx_ports is None: common.error_exit('--tx-ports') else: - tx_ports = '"%s"' % args.tx_ports - lb_opts += ['--tx', tx_ports, '\\'] + lb_opts += ['--tx', '"{:s}"'.format(args.tx_ports), '\\'] if args.worker_lcores is None: common.error_exit('--worker-lcores') else: - worker_lcores = '%s' % args.worker_lcores - lb_opts += ['--w', worker_lcores, '\\'] + lb_opts += ['--w', '{:s}'.format(args.worker_lcores), '\\'] if args.lpm is None: common.error_exit('--lpm') else: - lpm = '"%s"' % args.lpm - lb_opts += ['--lpm', lpm, '\\'] + lb_opts += ['--lpm', '"{:s}"'.format(args.lpm), '\\'] # Check optional opitons. if args.ring_sizes is not None: - lb_opts += [ - '--ring-sizes', args.ring_sizes, '\\'] + lb_opts += ['--ring-sizes', args.ring_sizes, '\\'] if args.burst_sizes is not None: - lb_opts += [ - '--burst-sizes', args.burst_sizes, '\\'] + lb_opts += ['--burst-sizes', args.burst_sizes, '\\'] if args.pos_lb is not None: - lb_opts += [ - '--pos-lb', str(args.pos_lb)] + lb_opts += ['--pos-lb', str(args.pos_lb)] cmds = docker_cmd + docker_opts + lb_cmd + eal_opts + lb_opts if cmds[-1] == '\\': -- 2.17.1