From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2E71A0524 for ; Tue, 25 Feb 2020 11:35:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA6581BC24; Tue, 25 Feb 2020 11:35:23 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by dpdk.org (Postfix) with ESMTP id 1F58B1BFB3 for ; Tue, 25 Feb 2020 11:35:22 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id p14so6963204pfn.4 for ; Tue, 25 Feb 2020 02:35:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references; bh=v3uKG9AXItlTFWyxLGWuCeBzX2jhpTLz8MrBOmi1DW8=; b=tWVVw0YInl0ufZdD1A6tX/Zz5hzwXP4nEA4A5TDj8zsqTGVefm5paiH3NNJftXnsKR HfesYf7RZB/zs7NSQt5iW23vlDXk2F0w5lb8Fb9qdY7gM9NEWxer8YI/J3s+3EJKNtyy F8TMkjpr8rSSuKPVGRsjARe01g/m053ZZaRRPetIj27fZ+ghVRNDJiyZn5Rm0iZGYyU/ GWGVprssRSvZGW5wZc80Nwghoy7tCsIy3R8cX1riTiwIi91J4uQt45axSi+/XdzqhtgL c0g9w4EJXvrCxi26eE3LECOTijAS9ZF8yB7J0/oLMJSmFUGe1ofwQvpddiyrU0M32v8I Zp+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=v3uKG9AXItlTFWyxLGWuCeBzX2jhpTLz8MrBOmi1DW8=; b=HgMB9P4hzatM0j8l7QL8NHY2ZrT8855VPh0cj1L3VOlHTGsJWKIt1FO8uhbDohP7Dz 8X8eVTVzdthd0oadLM2ud5PMqJJkWYZTiamLd8RC0ltvo/Q3SatmDbssG5B25dR+HFJY dwW7KWVHZ+yMbOqAHMqyPOE83ZFGy5FcqLZkYgJXDBlOna+rqNcmnqTIjWAeqXLjg9/r bhZfiWFn+rLP2Yo8qqU+CRRXinGpjEioIkkrjJMMmbs8evWtH7F0bBLGsMQuEFGuafMG en92bZdHIiSYe3cAKtuKWEUK5+UoZBOvNhmzI9RaHj/00DG4BSroyXCvSaJAahtv4gRP lUmw== X-Gm-Message-State: APjAAAV3BWx3VpWv86/RayPGQ1qUHJ+O65qp7Wmh5B2AE8oPuzghkPdt msC4gR4pmWSp4rD6R17M3Z0iuZ8M X-Google-Smtp-Source: APXvYqw8KdgYQJJnRysSC9KBTf43WkxkzrZK96V8pkRzrWv+52ZKUF88KMtCqH2oYwj+A69SvtigOA== X-Received: by 2002:a62:ab13:: with SMTP id p19mr55114836pff.98.1582626921131; Tue, 25 Feb 2020 02:35:21 -0800 (PST) Received: from localhost.localdomain ([2400:4050:c8c2:de00:35bc:b9a3:f404:3cf2]) by smtp.gmail.com with ESMTPSA id a10sm15819987pgk.71.2020.02.25.02.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 02:35:20 -0800 (PST) From: Yasufumi Ogawa To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com Date: Tue, 25 Feb 2020 19:34:34 +0900 Message-Id: <20200225103446.8243-18-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200225103446.8243-1-yasufum.o@gmail.com> References: <20200225103446.8243-1-yasufum.o@gmail.com> Subject: [spp] [PATCH 17/29] tools/sppc: update dev options of helloworld X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Update options for vdevs of helloworld container app. Signed-off-by: Yasufumi Ogawa --- tools/sppc/app/helloworld.py | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/tools/sppc/app/helloworld.py b/tools/sppc/app/helloworld.py index d155b64..3b0b021 100755 --- a/tools/sppc/app/helloworld.py +++ b/tools/sppc/app/helloworld.py @@ -29,6 +29,7 @@ def parse_args(): def main(): args = parse_args() + app_name = 'helloworld' # Container image name such as 'sppc/dpdk-ubuntu:18.04' if args.container_image is not None: @@ -38,32 +39,38 @@ def main(): common.IMG_BASE_NAMES['dpdk'], args.dist_name, args.dist_ver) - # Check for other mandatory opitons. - if args.dev_ids is None: - common.error_exit('--dev-ids') + # Setup devices with given device UIDs. + dev_uids = None + sock_files = None + if args.dev_uids is not None: + if app_helper.is_valid_dev_uids(args.dev_uids) is False: + print('Invalid option: {}'.format(args.dev_uids)) + exit() - # Setup for vhost devices with given device IDs. - dev_ids_list = app_helper.dev_ids_to_list(args.dev_ids) - sock_files = app_helper.sock_files(dev_ids_list) + dev_uids_list = args.dev_uids.split(',') + sock_files = app_helper.sock_files(dev_uids_list) # Setup docker command. docker_cmd = ['sudo', 'docker', 'run', '\\'] - docker_opts = app_helper.setup_docker_opts( - args, container_image, sock_files) + docker_opts = app_helper.setup_docker_opts(args, sock_files) # Setup helloworld run on container. - cmd_path = '%s/examples/helloworld/%s/helloworld' % ( - env.RTE_SDK, env.RTE_TARGET) + cmd_path = '{0:s}/examples/{2:s}/{1:s}/{2:s}'.format( + env.RTE_SDK, env.RTE_TARGET, app_name) hello_cmd = [cmd_path, '\\'] - file_prefix = 'spp-hello-container%d' % dev_ids_list[0] + if args.name is not None: + file_prefix = app_helper.gen_sppc_file_prefix(args.name) + else: + file_prefix = app_helper.gen_sppc_file_prefix(app_name) eal_opts = app_helper.setup_eal_opts(args, file_prefix) # No application specific options for helloworld hello_opts = [] - cmds = docker_cmd + docker_opts + hello_cmd + eal_opts + hello_opts + cmds = docker_cmd + docker_opts + [container_image] + hello_cmd + \ + eal_opts + hello_opts if cmds[-1] == '\\': cmds.pop() common.print_pretty_commands(cmds) -- 2.17.1