From: Yasufumi Ogawa <yasufum.o@gmail.com>
To: spp@dpdk.org, ferruh.yigit@intel.com, yasufum.o@gmail.com
Subject: [spp] [PATCH 19/29] tools/sppc: update dev options of spp_nfv
Date: Tue, 25 Feb 2020 19:34:36 +0900 [thread overview]
Message-ID: <20200225103446.8243-20-yasufum.o@gmail.com> (raw)
In-Reply-To: <20200225103446.8243-1-yasufum.o@gmail.com>
Update options for vdevs of spp_nfv container app.
Signed-off-by: Yasufumi Ogawa <yasufum.o@gmail.com>
---
tools/sppc/app/spp-nfv.py | 45 ++++++++++++++++-------------------
tools/sppc/app/spp-primary.py | 1 +
2 files changed, 22 insertions(+), 24 deletions(-)
diff --git a/tools/sppc/app/spp-nfv.py b/tools/sppc/app/spp-nfv.py
index da9853b..3d608f3 100755
--- a/tools/sppc/app/spp-nfv.py
+++ b/tools/sppc/app/spp-nfv.py
@@ -18,6 +18,7 @@ def parse_args():
description="Launcher for spp-nfv application container")
parser = app_helper.add_eal_args(parser)
+ parser = app_helper.add_appc_args(parser)
# Application specific arguments
parser.add_argument(
@@ -35,16 +36,16 @@ def parse_args():
help="Port for secondary of spp-ctl")
parser = app_helper.add_sppc_args(parser)
-
return parser.parse_args()
def main():
args = parse_args()
+ app_name = 'spp_nfv'
+
# Setup docker command.
docker_cmd = ['sudo', 'docker', 'run', '\\']
- docker_opts = []
# Container image name such as 'sppc/spp-ubuntu:18.04'
if args.container_image is not None:
@@ -54,33 +55,28 @@ def main():
common.IMG_BASE_NAMES['spp'],
args.dist_name, args.dist_ver)
- # This container is running in backgroud in defualt.
- if args.foreground is not True:
- docker_opts += ['-d', '\\']
- else:
- docker_opts += ['-it', '\\']
-
- docker_opts += [
- '--privileged', '\\', # should be privileged
- '-v', '/dev/hugepages:/dev/hugepages', '\\',
+ app_opts = [
'-v', '/var/run/:/var/run/', '\\',
- '-v', '/tmp/:/tmp/', '\\',
- container_image, '\\'
- ]
+ '-v', '/tmp/:/tmp/', '\\']
+
+ docker_opts = app_helper.setup_docker_opts(
+ args, None, app_opts)
# Setup spp_nfv command.
- spp_cmd = ['spp_nfv', '\\']
+ spp_cmd = [app_name, '\\']
# Do not use 'app_helper.setup_eal_opts()' because spp_nfv does
# not use virtio.
- core_opt = app_helper.get_core_opt(args)
- mem_opt = app_helper.get_mem_opt(args)
- eal_opts = [
- core_opt['attr'], core_opt['val'], '\\',
- '-n', str(args.nof_memchan), '\\',
- mem_opt['attr'], mem_opt['val'], '\\',
- '--proc-type', 'secondary', '\\',
- '--', '\\']
+ #core_opt = app_helper.get_core_opt(args)
+ #mem_opt = app_helper.get_mem_opt(args)
+ #eal_opts = [
+ # core_opt['attr'], core_opt['val'], '\\',
+ # '-n', str(args.nof_memchan), '\\',
+ # mem_opt['attr'], mem_opt['val'], '\\',
+ # '--proc-type', 'secondary', '\\',
+ # '--', '\\']
+ eal_opts = app_helper.setup_eal_opts(args, common.SPPC_FILE_PREFIX,
+ proc_type='secondary')
spp_opts = []
# Check for other mandatory opitons.
@@ -97,7 +93,8 @@ def main():
else:
spp_opts += ['-s', '{}:{}'.format(ctl_ip, args.ctl_port), '\\']
- cmds = docker_cmd + docker_opts + spp_cmd + eal_opts + spp_opts
+ cmds = docker_cmd + docker_opts + [container_image, '\\'] + \
+ spp_cmd + eal_opts + spp_opts
if cmds[-1] == '\\':
cmds.pop()
common.print_pretty_commands(cmds)
diff --git a/tools/sppc/app/spp-primary.py b/tools/sppc/app/spp-primary.py
index 80b0c7b..5cc12ed 100755
--- a/tools/sppc/app/spp-primary.py
+++ b/tools/sppc/app/spp-primary.py
@@ -62,6 +62,7 @@ def main():
# Setup devices with given device UIDs.
dev_uids_list = None
+ # TODO(yasufum) Remove no need sock_files
sock_files = []
if args.dev_uids is not None:
if app_helper.is_valid_dev_uids(args.dev_uids) is False:
--
2.17.1
next prev parent reply other threads:[~2020-02-25 10:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 10:34 [spp] [PATCH 00/29] Update SPP Container tools Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 01/29] tools/sppc: update options for assigning devices Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 02/29] tools/sppc: update dev options of l2fwd Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 03/29] tools/sppc: add container name option Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 04/29] tools/sppc: update l2fwd app for " Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 05/29] tools/sppc: update dev options of l3fwd Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 06/29] tools/sppc: update dev options of l3fwd-acl Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 07/29] tools/sppc: update dev options of testpmd Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 08/29] tools/sppc: update dev options of pktgen Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 09/29] tools/sppc: update dev options of load-balancer Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 10/29] tools/sppc: version checker for container DPDK ver Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 11/29] tools/sppc: check DPDK ver in load-balancer Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 12/29] tools/sppc: setup spp_pri opts in app_helper Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 13/29] tools/sppc: define file prefix for SPP Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 14/29] tools/sppc: update dev options of spp_primary Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 15/29] tools/sppc: setup with docker opts in SPP pri Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 16/29] tools/sppc: update calling setup_docker_opts() Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 17/29] tools/sppc: update dev options of helloworld Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 18/29] tools/sppc: update dev options of suricata Yasufumi Ogawa
2020-02-25 10:34 ` Yasufumi Ogawa [this message]
2020-02-25 10:34 ` [spp] [PATCH 20/29] tools/sppc: change to gen EAL opts with app name Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 21/29] tools/sppc: remove nouse variable Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 22/29] bin: remove sock files created by docker Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 23/29] tools/sppc: skip checking rule file if dry run Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 24/29] docs: revise examples in sppc Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 25/29] docs: update versions in " Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 26/29] docs: update old example in spp_primary container Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 27/29] tools/sppc: python3 support for sppc build tool Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 28/29] docs: update app container help msg Yasufumi Ogawa
2020-02-25 10:34 ` [spp] [PATCH 29/29] docs: update howto define app container guide Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200225103446.8243-20-yasufum.o@gmail.com \
--to=yasufum.o@gmail.com \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).