From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36AA7A04A3 for ; Tue, 16 Jun 2020 10:28:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B1E61BECF; Tue, 16 Jun 2020 10:28:47 +0200 (CEST) Received: from dish-sg.nttdocomo.co.jp (dish-sg.nttdocomo.co.jp [202.19.227.74]) by dpdk.org (Postfix) with ESMTP id B34181BEC3 for ; Tue, 16 Jun 2020 10:28:44 +0200 (CEST) X-dD-Source: Outbound Received: from zssg-mailmd106.ddreams.local (zssg-mailmd900.ddreams.local [10.160.172.63]) by zssg-mailou104.ddreams.local (Postfix) with ESMTP id 129861200F1; Tue, 16 Jun 2020 17:28:43 +0900 (JST) Received: from t131sg-mailcc12.ddreams.local (t131sg-mailcc12.ddreams.local [100.66.31.87]) by zssg-mailmd106.ddreams.local (dDREAMS) with ESMTP id <0QC000OEJFJUQY60@dDREAMS>; Tue, 16 Jun 2020 17:28:43 +0900 (JST) Received: from t131sg-mailcc11 (localhost [127.0.0.1]) by t131sg-mailcc12.ddreams.local (unknown) with SMTP id 05G8SgNW027037; Tue, 16 Jun 2020 17:28:42 +0900 Received: from zssg-mailmf101.ddreams.local (unknown [127.0.0.1]) by zssg-mailmf101.ddreams.local (Postfix) with ESMTP id 164477E603A; Tue, 16 Jun 2020 17:28:25 +0900 (JST) Received: from zssg-mailmf101.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 143048E6056; Tue, 16 Jun 2020 17:28:25 +0900 (JST) Received: from localhost (unknown [127.0.0.1]) by IMSVA (Postfix) with SMTP id 04ECC8E6054; Tue, 16 Jun 2020 17:28:25 +0900 (JST) X-IMSS-HAND-OFF-DIRECTIVE: localhost:10026 Received: from zssg-mailmf101.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E775D8E6055; Tue, 16 Jun 2020 17:28:23 +0900 (JST) Received: from zssg-mailua103.ddreams.local (unknown [10.160.172.62]) by zssg-mailmf101.ddreams.local (Postfix) with ESMTP; Tue, 16 Jun 2020 17:28:23 +0900 (JST) Received: from [10.87.198.18] (unknown [10.160.183.129]) by zssg-mailua103.ddreams.local (dDREAMS) with ESMTPA id <0QC000MDZFJ7SV71@dDREAMS>; Tue, 16 Jun 2020 17:28:19 +0900 (JST) Date: Tue, 16 Jun 2020 17:28:19 +0900 From: Hideyuki Yamashita In-reply-to: <41d3d83f-3908-6c60-796c-cfa5af41d6f0@gmail.com> References: <20200605002854.24054-4-x-fn-spp-ml@ntt-tx.co.jp> <41d3d83f-3908-6c60-796c-cfa5af41d6f0@gmail.com> Message-id: <20200616172818.B8F2.17218CA3@ntt-tx.co.jp_1> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Becky! ver. 2.74.02 [ja] X-TM-AS-GCONF: 00 To: Yasufumi Ogawa Cc: x-fn-spp-ml@ntt-tx.co.jp, spp@dpdk.org Subject: Re: [spp] (x-fn-spp-ml 781) Re: [PATCH 3/5] docs: catch up updates in dpdk-20.02 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Hi, Sorry for delayed reply. Please see inline comments. > Hi, > > Thanks for your update. I have three comments. > > > From: Hideyuki Yamashita > > > > This patch catch up the following updates in dpdk-20.02. > > - new config to generate IGB_UIO module > > - change supported target from x86_64-native-linuxapp-gcc to > > x86_64_native-linux-gcc > Plese take care about indenting. Sure I will modify as follwing in next update > > - new config to generate IGB_UIO module > > - change supported target from x86_64-native-linuxapp-gcc to > > x86_64_native-linux-gcc > > > > Signed-off-by: Hideyuki Yamashita > > Signed-off-by: Naoki Takada > > --- > > docs/guides/gsg/howto_use.rst | 20 ++++++++++---------- > > docs/guides/gsg/install.rst | 9 ++++++--- > > docs/guides/tools/sppc/app_launcher.rst | 2 +- > > docs/guides/usecases/spp_mirror.rst | 10 +++++----- > > docs/guides/usecases/spp_pcap.rst | 4 ++-- > > docs/guides/usecases/spp_vf.rst | 8 ++++---- > > 6 files changed, 28 insertions(+), 25 deletions(-) > > > [...] > > > diff --git a/docs/guides/gsg/install.rst b/docs/guides/gsg/install.rst > > index 2abf330..f561f60 100644 > > --- a/docs/guides/gsg/install.rst > > +++ b/docs/guides/gsg/install.rst > > @@ -119,8 +119,9 @@ Installing on Ubuntu and CentOS are almost the same, but required packages > > are just bit different. > > > PCAP is disabled by default in DPDK configuration. > > -``CONFIG_RTE_LIBRTE_PMD_PCAP`` and ``CONFIG_RTE_PORT_PCAP`` defined in > > -config file ``common_base`` should be changed to ``y`` to enable PCAP. > > +``CONFIG_RTE_LIBRTE_PMD_PCAP``, ``CONFIG_RTE_PORT_PCAP`` and > > +``CONFIG_RTE_EAL_IGB_UIO`` defined in config file ``common_base`` should be > This sentence is to give a instruction for using PCAP, so should not include about IGB_UIO in the same sentence. Could you separate the sentence and add an explanation that igb_uio is no longer built as default? Sure. I will de-couple setting of ``CONFIG_RTE_EAL_IGB_UIO`` from those of PCAP. > > +changed to ``y`` to enable PCAP. > > > .. code-block:: console > > > @@ -128,6 +129,8 @@ config file ``common_base`` should be changed to ``y`` to enable PCAP. > > CONFIG_RTE_LIBRTE_PMD_PCAP=y > > ... > > CONFIG_RTE_PORT_PCAP=y > > + ... > > + CONFIG_RTE_EAL_IGB_UIO=y > Please separate as similar to previous one. Sure. > > > If you use MLX5 NIC, ``CONFIG_RTE_LIBRTE_MLX5_PMD`` defined in > > config file ``common_base`` should be changed to ``y``. > > @@ -143,7 +146,7 @@ Compile DPDK with target environment. > > > $ cd dpdk > > $ export RTE_SDK=$(pwd) > > - $ export RTE_TARGET=x86_64-native-linuxapp-gcc # depends on your env > > + $ export RTE_TARGET=x86_64-native-linux-gcc # depends on your env > > $ make install T=$RTE_TARGET > > > Pyhton > > diff --git a/docs/guides/tools/sppc/app_launcher.rst b/docs/guides/tools/sppc/app_launcher.rst > > index b368a15..40f40ca 100644 > > --- a/docs/guides/tools/sppc/app_launcher.rst > > +++ b/docs/guides/tools/sppc/app_launcher.rst > > @@ -831,7 +831,7 @@ and three vhost interfaces. > > sudo docker run \ > > ... > > sppc/pktgen-ubuntu:latest \ > > - /root/dpdk/../pktgen-dpdk/app/x86_64-native-linuxapp-gcc/pktgen \ > > + /root/dpdk/../pktgen-dpdk/app/x86_64-native-linux-gcc/pktgen \ > > -l 8-14 \ > > ... > > -- \ > > diff --git a/docs/guides/usecases/spp_mirror.rst b/docs/guides/usecases/spp_mirror.rst > > index 4164a16..00d6eef 100644 > > --- a/docs/guides/usecases/spp_mirror.rst > > +++ b/docs/guides/usecases/spp_mirror.rst > > @@ -70,7 +70,7 @@ three ports ``-p 0x07``. > > .. code-block:: console > > > # terminal 3 > > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > > -l 1 -n 4 \ > > --socket-mem 512,512 \ > > --huge-dir=/run/hugepages/kvm \ > > @@ -87,7 +87,7 @@ Run secondary process ``spp_mirror``. > > .. code-block:: console > > > # terminal 4 > > - $ sudo ./src/mirror/x86_64-native-linuxapp-gcc/app/spp_mirror \ > > + $ sudo ./src/mirror/x86_64-native-linux-gcc/app/spp_mirror \ > > -l 0,2 -n 4 \ > > --proc-type secondary \ > > -- \ > > @@ -230,7 +230,7 @@ Start spp_primary with core list option ``-l 1``. > > > # terminal 3 > > # Type the following in different terminal > > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > > -l 1 -n 4 \ > > --socket-mem 512,512 \ > > --huge-dir=/run/hugepages/kvm \ > > @@ -261,7 +261,7 @@ Launch ``VM1``, ``VM2`` and ``spp_vf`` with core list ``-l 0,2-8``. > > .. code-block:: console > > > # terminal 4 > > - $ sudo ./src/vf/x86_64-native-linuxapp-gcc/spp_vf \ > > + $ sudo ./src/vf/x86_64-native-linux-gcc/spp_vf \ > > -l 0,2-8 \ > > -n 4 --proc-type secondary \ > > -- \ > > @@ -329,7 +329,7 @@ Run ``spp_mirror``. > > .. code-block:: console > > > # terminal 6 > > - $ sudo ./src/mirror/x86_64-native-linuxapp-gcc/app/spp_mirror \ > > + $ sudo ./src/mirror/x86_64-native-linux-gcc/app/spp_mirror \ > > -l 0,9 \ > > -n 4 --proc-type secondary \ > > -- \ > > diff --git a/docs/guides/usecases/spp_pcap.rst b/docs/guides/usecases/spp_pcap.rst > > index 543538d..e94cfc4 100644 > > --- a/docs/guides/usecases/spp_pcap.rst > > +++ b/docs/guides/usecases/spp_pcap.rst > > @@ -59,7 +59,7 @@ Then, run ``spp_primary`` with one physical port. > > .. code-block:: console > > > # terminal 3 > > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > > -l 0 -n 4 \ > > --socket-mem 512,512 \ > > --huge-dir /run/hugepages/kvm \ > > @@ -79,7 +79,7 @@ writer threads. > > .. code-block:: console > > > # terminal 4 > > - $ sudo ./src/pcap/x86_64-native-linuxapp-gcc/spp_pcap \ > > + $ sudo ./src/pcap/x86_64-native-linux-gcc/spp_pcap \ > > -l 1-6 -n 4 --proc-type=secondary \ > > -- \ > > --client-id 1 -s 192.168.1.100:6666 \ > > diff --git a/docs/guides/usecases/spp_vf.rst b/docs/guides/usecases/spp_vf.rst > > index c45feb8..6056636 100644 > > --- a/docs/guides/usecases/spp_vf.rst > > +++ b/docs/guides/usecases/spp_vf.rst > > @@ -52,7 +52,7 @@ Launch ``spp-ctl`` and SPP CLI before primary and secondary processes. > > .. code-block:: console > > > # terminal 3 > > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > > -l 1 -n 4 \ > > --socket-mem 512,512 \ > > --huge-dir=/run/hugepages/kvm \ > > @@ -68,7 +68,7 @@ worker threads. > > .. code-block:: console > > > # terminal 4 > > - $ sudo ./src/vf/x86_64-native-linuxapp-gcc/spp_vf \ > > + $ sudo ./src/vf/x86_64-native-linux-gcc/spp_vf \ > > -l 2-6 \ > > -n 4 --proc-type=secondary \ > > -- \ > > @@ -281,7 +281,7 @@ Launch ``spp-ctl`` and SPP CLI before primary and secondary processes. > > .. code-block:: console > > > # terminal 3 > > - $ sudo ./src/primary/x86_64-native-linuxapp-gcc/spp_primary \ > > + $ sudo ./src/primary/x86_64-native-linux-gcc/spp_primary \ > > -l 1 -n 4 \ > > --socket-mem 512,512 \ > > --huge-dir=/run/hugepages/kvm \ > > @@ -295,7 +295,7 @@ to use twelve lcores. > > .. code-block:: console > > > # terminal 4 > > - $ sudo ./src/vf/x86_64-native-linuxapp-gcc/spp_vf \ > > + $ sudo ./src/vf/x86_64-native-linux-gcc/spp_vf \ > > -l 0,2-13 \ > > -n 4 --proc-type=secondary \ > > -- \ > >