From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 544B3A04A5 for ; Thu, 18 Jun 2020 01:19:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1863B1150; Thu, 18 Jun 2020 01:19:34 +0200 (CEST) Received: from mail.valinux.co.jp (mail.valinux.co.jp [210.128.90.3]) by dpdk.org (Postfix) with ESMTP id 569B31150 for ; Thu, 18 Jun 2020 01:19:32 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail.valinux.co.jp (Postfix) with ESMTP id 2DC18A02B7; Thu, 18 Jun 2020 08:19:31 +0900 (JST) X-Virus-Scanned: Debian amavisd-new at valinux.co.jp Received: from mail.valinux.co.jp ([127.0.0.1]) by localhost (mail.valinux.co.jp [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V1n6-CT99m_B; Thu, 18 Jun 2020 08:19:31 +0900 (JST) Received: from [127.0.0.1] (vagw.valinux.co.jp [210.128.90.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.valinux.co.jp (Postfix) with ESMTPS id 1558FA029D; Thu, 18 Jun 2020 08:19:31 +0900 (JST) Date: Thu, 18 Jun 2020 08:19:31 +0900 From: Itsuro ODA To: Yasufumi Ogawa Cc: spp@dpdk.org In-Reply-To: References: <20200611233112.5976-1-oda@valinux.co.jp> Message-Id: <20200618081931.A1F4.277DD91C@valinux.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.74.02 [ja] Subject: Re: [spp] [PATCH] tools/sppc: improvement of Dockerfile for SPP container X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Hi Yasufumi, The spp_mirror container surely ran with networking-spp k8s environment. About the spp_pcap container, it is confirmed to start at least although detailed test are not done. Thanks. Itsuro Oda On Tue, 16 Jun 2020 18:33:32 +0900 Yasufumi Ogawa wrote: > > This patch includes some improvements of Dockerfile used by > > building SPP containers. > > > > * remove a nonexistent command path > > * add some useful command paths > > * specify a value of 'make -j' option of making DPDK not to > > exhaust system resources by compiling processes. > I totally agree with your changes, but have one thing to be confirmed. > > I remember that I haven't included spp_mirror and spp_pcap in apps in SPP container because I don't have tested well yet. Have you confirmed that these app run on container env? > > > > > Signed-off-by: Itsuro Oda > > --- > > tools/sppc/build/ubuntu/spp/Dockerfile.16.04 | 5 +++-- > > tools/sppc/build/ubuntu/spp/Dockerfile.18.04 | 5 +++-- > > tools/sppc/build/ubuntu/spp/Dockerfile.latest | 5 +++-- > > 3 files changed, 9 insertions(+), 6 deletions(-) > > > > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > > index 3e060df..7c81b3a 100644 > > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > > > WORKDIR $home_dir > > RUN git clone ${dpdk_branch} ${dpdk_repo} > > @@ -27,7 +28,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > > # Compile DPDK and SPP > > WORKDIR ${rte_sdk} > > -RUN make -j install T=${rte_target} > > +RUN make -j 4 install T=${rte_target} > > > WORKDIR ${home_dir}/${spp_dir} > > RUN make -j > > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > > index e35fbc2..9b90dd4 100644 > > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > > ENV DEBIAN_FRONTEND noninteractive > > > WORKDIR $home_dir > > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > > # Compile DPDK and SPP > > WORKDIR ${rte_sdk} > > -RUN make -j install T=${rte_target} > > +RUN make -j 4 install T=${rte_target} > > > WORKDIR ${home_dir}/${spp_dir} > > RUN make -j > > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.latest b/tools/sppc/build/ubuntu/spp/Dockerfile.latest > > index a1ffc80..7e6f5ac 100644 > > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.latest > > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.latest > > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > > ENV DEBIAN_FRONTEND noninteractive > > > WORKDIR $home_dir > > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > > # Compile DPDK and SPP > > WORKDIR ${rte_sdk} > > -RUN make -j install T=${rte_target} > > +RUN make -j 4 install T=${rte_target} > > > WORKDIR ${home_dir}/${spp_dir} > > RUN make -j > > -- Itsuro ODA