From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Cc: "spp@dpdk.org" <spp@dpdk.org>
Subject: Re: [spp] [PATCH 1/2] spp: update to improve usability
Date: Thu, 22 Feb 2018 11:35:54 +0000 [thread overview]
Message-ID: <3b6069b3-5eb7-8f6f-0a84-c68c937fdaca@intel.com> (raw)
In-Reply-To: <1518103091-4624-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp>
On 2/8/2018 3:18 PM, ogawa.yasufumi@lab.ntt.co.jp (ogawa.yasufumi@lab.ntt.co.jp)
wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>
> SPP controller executes previous command if user just types enter in
> command line. It decreases usability and might cause a wrong operation.
> In addition, users cannot use empty lines in config files loaded from
> `playback` command. It also decreases maintainability.
>
> For maintainability, it is another problem for SPP controller does not
> accept comment line from CLI (only able to use only in config file).
> User cannot record comment in 'record' command for the reason.
>
> This patch includes following updates.
>
> * Override emptyline() of Shell class to not repeat previous command.
>
> * Override default() to accept comment line. To find the comment, add
> is_comment_line() which support python and C style comment.
>
> * Remove lower() for user's input to avoid unexpected behaviour.
>
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-02-22 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 15:18 ogawa.yasufumi
2018-02-08 15:18 ` [spp] [PATCH 2/2] spp_vf: " ogawa.yasufumi
2018-02-22 11:50 ` Ferruh Yigit
2018-02-28 10:27 ` Yasufumi Ogawa
2018-02-22 11:35 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b6069b3-5eb7-8f6f-0a84-c68c937fdaca@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).