From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 1A7F32C18 for ; Thu, 22 Feb 2018 12:35:57 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2018 03:35:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,377,1515484800"; d="scan'208";a="22173254" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.35]) ([10.237.220.35]) by fmsmga002.fm.intel.com with ESMTP; 22 Feb 2018 03:35:55 -0800 To: Yasufumi Ogawa References: <1518103091-4624-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> Cc: "spp@dpdk.org" From: Ferruh Yigit Message-ID: <3b6069b3-5eb7-8f6f-0a84-c68c937fdaca@intel.com> Date: Thu, 22 Feb 2018 11:35:54 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1518103091-4624-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH 1/2] spp: update to improve usability X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Feb 2018 11:35:58 -0000 On 2/8/2018 3:18 PM, ogawa.yasufumi@lab.ntt.co.jp (ogawa.yasufumi@lab.ntt.co.jp) wrote: > From: Yasufumi Ogawa > > SPP controller executes previous command if user just types enter in > command line. It decreases usability and might cause a wrong operation. > In addition, users cannot use empty lines in config files loaded from > `playback` command. It also decreases maintainability. > > For maintainability, it is another problem for SPP controller does not > accept comment line from CLI (only able to use only in config file). > User cannot record comment in 'record' command for the reason. > > This patch includes following updates. > > * Override emptyline() of Shell class to not repeat previous command. > > * Override default() to accept comment line. To find the comment, add > is_comment_line() which support python and C style comment. > > * Remove lower() for user's input to avoid unexpected behaviour. > > Signed-off-by: Yasufumi Ogawa Series applied to dpdk-next-net/master, thanks.