Soft Patch Panel
 help / color / mirror / Atom feed
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com
Cc: spp@dpdk.org
Subject: Re: [spp] [PATCH] docs: add how to specify default route to classifier_table
Date: Wed, 22 Aug 2018 13:22:41 +0900	[thread overview]
Message-ID: <3d6bbd43-9e9a-fb50-1979-2f9afe912373@lab.ntt.co.jp> (raw)
In-Reply-To: <201807300510.w6U5AZdT010188@imss03.silk.ntt-tx.co.jp>

> From: Hideyuki <yamashita.hideyuki@po.ntt-tx.co.jp>
> 
> This patch adds how to specify default route to classifier_table.
> 
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
>   docs/guides/spp_vf/commands/secondary.rst | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/docs/guides/spp_vf/commands/secondary.rst b/docs/guides/spp_vf/commands/secondary.rst
> index 58ccec5..872c162 100644
> --- a/docs/guides/spp_vf/commands/secondary.rst
> +++ b/docs/guides/spp_vf/commands/secondary.rst
> @@ -215,6 +215,15 @@ This is an example to register an entry for port ``ring:0``.
>   
>       spp > sec 1;classifier_table add mac 52:54:00:01:00:01 ring:0
First, you also should update before this line. The word 'entry' is a little ambiguous. Here is my proposal.

From:
This is an example to register an entry for port ``ring:0``.

To:
This is an example to register MAC address ``52:54:00:01:00:01``
with resource ID ``ring:0``.

>   
> +The difference is this example uses ``default`` instead of ``52:54:00:01:00:01`` to forward packets to ``ring:0`` if packets does not match any of registered
> +MAC address.
Second, It is too long. It should be less than 80 chars per one line.

I do not understand what is 'the difference' because you do not mention about the another example at first. Do you think 
changing it like this one.

Here is another example in which using keyword ``default`` instead of ``52:54:00:01:00:01``.
``default`` is used for packets which are not matched any of registered MAC addresses.
In this case, all of not matched packets are sent to ``ring:0``.

> +specifies default route and if the received packet
> +does not match any MAC address, then forwarded to specified default destination.
It is no need anymore.

> +
> +.. code-block:: console
> +
> +    spp > sec 0;classifier_table add mac default ring:0
> +
>   Register an entry with a VLAN ID to classifier table.
>   
>   .. code-block:: console
> @@ -228,6 +237,14 @@ for port ``ring:0``.
>   
>       spp > sec 0;classifier_table add vlan 101 52:54:00:01:00:01 ring:0
It is almost similar to the first comment above.

>   
> +The difference is this example uses ``default`` instead of ``52:54:00:01:00:01`` to forward packets to ``ring:1`` if packets does not match any of registered MAC address for specified VLAN_ID.
And it is also similar to the second comment above.

Thanks for your contribution.
> +specifies default route of the specified vlan and if the received packet
> +does not match any MAC address, then forwarded to specified default destination.
> +
> +.. code-block:: console
> +
> +    spp > sec 0;classifier_table add vlan 101 default ring:1
> +
>   Delete an entry.
>   
>   .. code-block:: console
> 

  reply	other threads:[~2018-08-22  4:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  5:10 x-fn-spp
2018-08-22  4:22 ` Yasufumi Ogawa [this message]
2018-08-27  0:50 ` [spp] [PATCH v2] docs: add default route for classifier_table x-fn-spp
2018-08-27  7:02   ` Yasufumi Ogawa
2018-09-20  8:28     ` Yasufumi Ogawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d6bbd43-9e9a-fb50-1979-2f9afe912373@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    --cc=x-fn-spp@sl.ntt-tx.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).