From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 520F92BF7 for ; Wed, 22 Aug 2018 06:24:59 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w7M4OvXJ021253; Wed, 22 Aug 2018 13:24:57 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id A9C1DEA7980; Wed, 22 Aug 2018 13:24:57 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 9F3F0EA7646; Wed, 22 Aug 2018 13:24:57 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 9B7EB4008F9; Wed, 22 Aug 2018 13:24:57 +0900 (JST) References: <201807300510.w6U5AZdT010188@imss03.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <3d6bbd43-9e9a-fb50-1979-2f9afe912373@lab.ntt.co.jp> Date: Wed, 22 Aug 2018 13:22:41 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201807300510.w6U5AZdT010188@imss03.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com Cc: spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH] docs: add how to specify default route to classifier_table X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 04:25:00 -0000 > From: Hideyuki > > This patch adds how to specify default route to classifier_table. > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > --- > docs/guides/spp_vf/commands/secondary.rst | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/docs/guides/spp_vf/commands/secondary.rst b/docs/guides/spp_vf/commands/secondary.rst > index 58ccec5..872c162 100644 > --- a/docs/guides/spp_vf/commands/secondary.rst > +++ b/docs/guides/spp_vf/commands/secondary.rst > @@ -215,6 +215,15 @@ This is an example to register an entry for port ``ring:0``. > > spp > sec 1;classifier_table add mac 52:54:00:01:00:01 ring:0 First, you also should update before this line. The word 'entry' is a little ambiguous. Here is my proposal. From: This is an example to register an entry for port ``ring:0``. To: This is an example to register MAC address ``52:54:00:01:00:01`` with resource ID ``ring:0``. > > +The difference is this example uses ``default`` instead of ``52:54:00:01:00:01`` to forward packets to ``ring:0`` if packets does not match any of registered > +MAC address. Second, It is too long. It should be less than 80 chars per one line. I do not understand what is 'the difference' because you do not mention about the another example at first. Do you think changing it like this one. Here is another example in which using keyword ``default`` instead of ``52:54:00:01:00:01``. ``default`` is used for packets which are not matched any of registered MAC addresses. In this case, all of not matched packets are sent to ``ring:0``. > +specifies default route and if the received packet > +does not match any MAC address, then forwarded to specified default destination. It is no need anymore. > + > +.. code-block:: console > + > + spp > sec 0;classifier_table add mac default ring:0 > + > Register an entry with a VLAN ID to classifier table. > > .. code-block:: console > @@ -228,6 +237,14 @@ for port ``ring:0``. > > spp > sec 0;classifier_table add vlan 101 52:54:00:01:00:01 ring:0 It is almost similar to the first comment above. > > +The difference is this example uses ``default`` instead of ``52:54:00:01:00:01`` to forward packets to ``ring:1`` if packets does not match any of registered MAC address for specified VLAN_ID. And it is also similar to the second comment above. Thanks for your contribution. > +specifies default route of the specified vlan and if the received packet > +does not match any MAC address, then forwarded to specified default destination. > + > +.. code-block:: console > + > + spp > sec 0;classifier_table add vlan 101 default ring:1 > + > Delete an entry. > > .. code-block:: console >