Soft Patch Panel
 help / color / mirror / Atom feed
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To: x-fn-spp@sl.ntt-tx.co.jp
Cc: ferruh.yigit@intel.com, spp@dpdk.org
Subject: Re: [spp] [PATCH v3 0/2] docs:fix error and improve document under spp_vf
Date: Thu, 17 May 2018 13:00:14 +0900	[thread overview]
Message-ID: <3fbbb1b7-54d5-b3f9-4dc6-c5fc67727d84@lab.ntt.co.jp> (raw)
In-Reply-To: <201805160849.w4G8nObr014474@imss04.silk.ntt-tx.co.jp>

On 2018/05/16 17:49, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hideyuki-Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> 
> Hello Yasufumi-san,
> 
> I followed your guidance and made following changes on patch set:
>    1.Additionally fix typo on "unmount" and add detailed descriptions about
>      fixed errors in commit message in the first patch(0001).
>    2.Unify usage of VM_NAME.And also change description around virsh edit
>      in the second patch(0002).
> 
Thank you for revising your patches. However, commit messages of both of patches are too long.

It is noticed that "commit message should be wrapped at 72 characters" in DPDK's contribution guide, or warned from 
dpdk/devtools/checkpatches.sh if it is over 75 chars. Basically, SPP is following with DPDK's guide.
> BR,
> Hideyuki Yamashita
> 
> Hideyuki-Yamashita (2):
>    docs: fix document error under spp_vf directory
>    docs: improve document under spp_vf directory
> 
>   docs/guides/spp_vf/gsg/build.rst          | 53 ++++++++++++++----
>   docs/guides/spp_vf/use_cases/usecase1.rst | 89 +++++++++++++++++--------------
>   2 files changed, 90 insertions(+), 52 deletions(-)
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs

  reply	other threads:[~2018-05-17  4:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09  5:43 [spp] [PATCH 0/2] doc:Fix " x-fn-spp
2018-05-09  6:33 ` Yasufumi Ogawa
2018-05-09  6:57   ` [spp] [PATCH v2 0/2] doc:fix " x-fn-spp
2018-05-16  8:49     ` [spp] [PATCH v3 0/2] docs:fix " x-fn-spp
2018-05-17  4:00       ` Yasufumi Ogawa [this message]
2018-05-17  6:41       ` [spp] [PATCH v4 " x-fn-spp
2018-05-17  8:18         ` [spp] [PATCH v5 " x-fn-spp
2018-05-17  9:46           ` Yasufumi Ogawa
2018-05-24 12:54             ` Ferruh Yigit
2018-05-17  8:18         ` [spp] [PATCH v5 1/2] docs: fix document error under spp_vf directory x-fn-spp
2018-05-17  8:18         ` [spp] [PATCH v5 2/2] docs: improve document " x-fn-spp
2018-05-17  6:41       ` [spp] [PATCH v4 1/2] docs: fix document error " x-fn-spp
2018-05-17  6:41       ` [spp] [PATCH v4 2/2] docs: improve document " x-fn-spp
2018-05-16  8:49     ` [spp] [PATCH v3 1/2] docs: fix document error " x-fn-spp
2018-05-16  8:49     ` [spp] [PATCH v3 2/2] docs: improve document " x-fn-spp
2018-05-09  6:58   ` [spp] [PATCH v2 1/2] docs: fix document error " x-fn-spp
2018-05-11  3:44     ` Yasufumi Ogawa
2018-05-09  6:58   ` [spp] [PATCH v2 2/2] docs: improve document " x-fn-spp
2018-05-11  4:23     ` Yasufumi Ogawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3fbbb1b7-54d5-b3f9-4dc6-c5fc67727d84@lab.ntt.co.jp \
    --to=ogawa.yasufumi@lab.ntt.co.jp \
    --cc=ferruh.yigit@intel.com \
    --cc=spp@dpdk.org \
    --cc=x-fn-spp@sl.ntt-tx.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).