From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 2B8595F2D for ; Thu, 17 May 2018 06:01:44 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w4H41hqK023192; Thu, 17 May 2018 13:01:43 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 17BEAEA7E55; Thu, 17 May 2018 13:01:43 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 0D38CEA7E37; Thu, 17 May 2018 13:01:43 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 0549E400874; Thu, 17 May 2018 13:01:43 +0900 (JST) References: <201805090657.w496vu1Y011405@imss04.silk.ntt-tx.co.jp> <201805160849.w4G8nObr014474@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <3fbbb1b7-54d5-b3f9-4dc6-c5fc67727d84@lab.ntt.co.jp> Date: Thu, 17 May 2018 13:00:14 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201805160849.w4G8nObr014474@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH v3 0/2] docs:fix error and improve document under spp_vf X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 04:01:45 -0000 On 2018/05/16 17:49, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hideyuki-Yamashita > > Hello Yasufumi-san, > > I followed your guidance and made following changes on patch set: > 1.Additionally fix typo on "unmount" and add detailed descriptions about > fixed errors in commit message in the first patch(0001). > 2.Unify usage of VM_NAME.And also change description around virsh edit > in the second patch(0002). > Thank you for revising your patches. However, commit messages of both of patches are too long. It is noticed that "commit message should be wrapped at 72 characters" in DPDK's contribution guide, or warned from dpdk/devtools/checkpatches.sh if it is over 75 chars. Basically, SPP is following with DPDK's guide. > BR, > Hideyuki Yamashita > > Hideyuki-Yamashita (2): > docs: fix document error under spp_vf directory > docs: improve document under spp_vf directory > > docs/guides/spp_vf/gsg/build.rst | 53 ++++++++++++++---- > docs/guides/spp_vf/use_cases/usecase1.rst | 89 +++++++++++++++++-------------- > 2 files changed, 90 insertions(+), 52 deletions(-) > -- Yasufumi Ogawa NTT Network Service Systems Labs