From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AEFDA04A5 for ; Thu, 18 Jun 2020 04:40:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EEDA51150; Thu, 18 Jun 2020 04:40:24 +0200 (CEST) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 694FE1150 for ; Thu, 18 Jun 2020 04:40:23 +0200 (CEST) Received: by mail-pf1-f196.google.com with SMTP id b16so2064798pfi.13 for ; Wed, 17 Jun 2020 19:40:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=5GWJqUaMMNPILo9Cle5VvoQxl9/k4EoqrV4reQQCGxM=; b=q6NWOBCk9aRykvBnwfpDkzpA7wwqMDoFTwSbafk2hvejqIVcMJU3w1jqCe4WBDIVhY F3Rktg8FBh3lVkUgM57d1Km1XMn411kycTDBXhgUVdX/44SjRrzNAT1zlM2F4WG4RIvg 9zGfUxWTGVCCKuZIG6mpbEcZE17ijX3WkFM7ugHu7kLGoxYY079uP1+XhJQHEbicnXbt B3lqVTn+zdx/l0sh50faN4YcwiQGDFwC2utq6IaKW1yKI6WeYdqQZ+hDnYW44xC2YjIW VoEfJCWAPqtbw/m6n0XYCh83DD4oED3myF9qpTLw3xrXPPsaapQWaFJnlT0vsyOe9Doe hVHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5GWJqUaMMNPILo9Cle5VvoQxl9/k4EoqrV4reQQCGxM=; b=hVsjyTAcPex61YcQ59dEOdxeSsmnSvbgCOcEWmvDMDlBhj9hxXSHzwgA5GzUELQLjx HVTnRW4VKWVLxQWeFRTINL82eOFCoUK6i9qDHMjVn3qCPibcyxYsYqKQHLFqI45Qlr+E 7P3LrKzST48qw4F25oxA/3xD/Kg7st/lWhe3kT1+bfkOzYX9mP57IN+LUffwIodpa6No xhJVS0MEO4KazjRa9Wa3wQXl9FE2SrevkXK5k10LSU+2NtStTBwbX14A5kT4YRfxtlzO OJsisJyas3GhD+wu3RSb4kYLzhKKPHCqRGT8LwT4vmXo2LtZr5cM1jBYaGWkSMK2YK/e vE9g== X-Gm-Message-State: AOAM5311oFSRoyYCqGOCuN65MDa+7DRhfDYsi1TwFVo5ftNTBgEicuVW RnXa7ZQDxsOT5Cf22cqrpUpqIb1blfE= X-Google-Smtp-Source: ABdhPJyN35bn6risgCOYfvPG0XT90ZzTJjovt8Wusf4CndJlMa54rI+tKP5K///iFhm59AznHZECDg== X-Received: by 2002:aa7:8ad4:: with SMTP id b20mr1648423pfd.268.1592448022176; Wed, 17 Jun 2020 19:40:22 -0700 (PDT) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id oc6sm755224pjb.43.2020.06.17.19.40.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 19:40:21 -0700 (PDT) To: Itsuro Oda References: <20200611233112.5976-1-oda@valinux.co.jp> Cc: spp@dpdk.org From: Yasufumi Ogawa Message-ID: <4932d982-b16d-2d8d-ada7-3b9bf3598511@gmail.com> Date: Thu, 18 Jun 2020 11:40:19 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200611233112.5976-1-oda@valinux.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH] tools/sppc: improvement of Dockerfile for SPP container X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" > This patch includes some improvements of Dockerfile used by > building SPP containers. > > * remove a nonexistent command path > * add some useful command paths > * specify a value of 'make -j' option of making DPDK not to > exhaust system resources by compiling processes. > > Signed-off-by: Itsuro Oda Applied, thanks! Acked-by: Yasufumi Ogawa > --- > tools/sppc/build/ubuntu/spp/Dockerfile.16.04 | 5 +++-- > tools/sppc/build/ubuntu/spp/Dockerfile.18.04 | 5 +++-- > tools/sppc/build/ubuntu/spp/Dockerfile.latest | 5 +++-- > 3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > index 3e060df..7c81b3a 100644 > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > > WORKDIR $home_dir > RUN git clone ${dpdk_branch} ${dpdk_repo} > @@ -27,7 +28,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > # Compile DPDK and SPP > WORKDIR ${rte_sdk} > -RUN make -j install T=${rte_target} > +RUN make -j 4 install T=${rte_target} > > WORKDIR ${home_dir}/${spp_dir} > RUN make -j > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > index e35fbc2..9b90dd4 100644 > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > ENV DEBIAN_FRONTEND noninteractive > > WORKDIR $home_dir > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > # Compile DPDK and SPP > WORKDIR ${rte_sdk} > -RUN make -j install T=${rte_target} > +RUN make -j 4 install T=${rte_target} > > WORKDIR ${home_dir}/${spp_dir} > RUN make -j > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.latest b/tools/sppc/build/ubuntu/spp/Dockerfile.latest > index a1ffc80..7e6f5ac 100644 > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.latest > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.latest > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > ENV DEBIAN_FRONTEND noninteractive > > WORKDIR $home_dir > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > # Compile DPDK and SPP > WORKDIR ${rte_sdk} > -RUN make -j install T=${rte_target} > +RUN make -j 4 install T=${rte_target} > > WORKDIR ${home_dir}/${spp_dir} > RUN make -j >