From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To: Itsuro ODA <oda@valinux.co.jp>
Cc: spp@dpdk.org, ferruh.yigit@intel.com
Subject: Re: [spp] [PATCH] spp-ctl: update to return primary status
Date: Wed, 10 Oct 2018 13:07:31 +0900 [thread overview]
Message-ID: <4f859686-1ad8-2c59-2fe5-5a49b71687bb@lab.ntt.co.jp> (raw)
In-Reply-To: <20181010062604.2DFE.277DD91C@valinux.co.jp>
> Hi Yasufumi,
>
> On Tue, 9 Oct 2018 19:53:24 +0900
> ogawa.yasufumi@lab.ntt.co.jp wrote:
>
>> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>>
>> Status command of primary is changed to return statistics of each of
>> ports. This update is to change spp-ctl to return the reponse.
>>
>> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>> ---
>> src/spp-ctl/spp_webapi.py | 8 ++++++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/spp-ctl/spp_webapi.py b/src/spp-ctl/spp_webapi.py
>> index 9c16af6..dd595a0 100644
>> --- a/src/spp-ctl/spp_webapi.py
>> +++ b/src/spp-ctl/spp_webapi.py
>> @@ -325,7 +325,6 @@ class V1NFVHandler(BaseHandler):
>> # that it has no dst port.
>> # {"status":"idling","ports":[{"src":"phy:0","dst":"null"},...
>>
>> - # TODO(yasufum) modify after nfv and vm is updated for new data definition.
>> try:
>> nfv = json.loads(data)
>> except json.JSONDecodeError as e:
>> @@ -402,7 +401,12 @@ class V1PrimaryHandler(BaseHandler):
>> # no data returned at the moment.
>> # some data will be returned when the primary becomes to
>> # return statistical information.
>
> These comment lines should be removed at the same time because
> its aim is to explain why no data returned and it is not
> necessary now.
It is my fault, not needed anymore. Thanks for reviewing!
>
>> - return {}
>> + stat = {}
>> + try:
>> + stat = json.loads(data)
>> + except json.JSONDecodeError as e:
>> + print("%s" % e)
>> + return stat
>>
>> def get_status(self):
>> proc = self._get_proc()
>> --
>> 2.7.4
>
> Thanks.
>
next prev parent reply other threads:[~2018-10-10 4:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 10:53 ogawa.yasufumi
2018-10-09 21:26 ` Itsuro ODA
2018-10-10 4:07 ` Yasufumi Ogawa [this message]
2018-10-11 10:40 ` [spp] [PATCH v2] " ogawa.yasufumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f859686-1ad8-2c59-2fe5-5a49b71687bb@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=oda@valinux.co.jp \
--cc=spp@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).