From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61D80A2EEB for ; Wed, 11 Sep 2019 08:47:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 46A501C2A3; Wed, 11 Sep 2019 08:47:05 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by dpdk.org (Postfix) with ESMTP id 643071C2A3 for ; Wed, 11 Sep 2019 08:47:03 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id r12so13075548pfh.1 for ; Tue, 10 Sep 2019 23:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:cc:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=45tzFcpvVzv6HJu9r/wRfy4yzZHcdKc4KyptiMh/nGc=; b=k4eXb5tWcrYaXgx+Qyn5fIU4qUJH/UaMrxRzlO4RnwuMqOvehmHOvuTM/coiezjXgH RuzWPOQYFMZIXi1SlENAFB+ZPwFYWpaZ4FiUgQ4HjsKWPIhIernrQXxfsnUpqkdCvirU MD5R//J/F3CrsJYtYWqV9WJCfysI9VxQK2Mxf65W+JCW75iKDdSlKCubB/H8r9vjBbv+ BiJpzIR5wcLSN2uPfVunun6244FjUJ9k9Vr8cIttGcAqASGEFayJKnHZEhUDxU5EW6e8 f8SwSK9NSiuQeLc8uxkSIfYoeWHcLRFLG5MjZI/SIL2s+b2+e6IgKjjeAyY/eeaL/JJx J3Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:cc:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=45tzFcpvVzv6HJu9r/wRfy4yzZHcdKc4KyptiMh/nGc=; b=EHUziGD5go0w41OaaXHMppa6k5Qtv4CRYO3nvowP7pXJgDo4etP66ydUgpJFKclWP4 gYTaxDUdqiAir5VytaJV1LAy7bZoCIZ/vi9+dKUE9ZS1xlHVb3xbxomVkHx1aKRx5CBH /oPTv8bMguR2FHqBkrZAU636aNL2YI86OI/ASlqxGuQPybcq+a7STFLfU1ysrbE9QuQJ lmw/eTXD7jVBFDJbwZVB+9BnAYkd+jXELYf6j3I9DGIt1qMJOfD4zakCvg/tAtvrKhQ7 Cxl/ZsTibcbBGxT0fSyhoY8UVagZyaTA5LJbOEmd5yfyD6usEgP6w9smhqkdd6dW1XLx RMpg== X-Gm-Message-State: APjAAAWBr/amuTmAP9zgdUv86LgPXkN5a5RkGnKzG2ioBmh9Uv8hP6YG AOSx8mLBnSB/pDaf811qO3wNOIF8 X-Google-Smtp-Source: APXvYqyKKrUjkEkZ3Paa8YIVYjd+l7WIA1C7trgbkv00/sdSOrfOm6el0rdAvalq1LCRJqmFSFZUBg== X-Received: by 2002:a63:cb4f:: with SMTP id m15mr31314478pgi.100.1568184422321; Tue, 10 Sep 2019 23:47:02 -0700 (PDT) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id 129sm24650321pfd.173.2019.09.10.23.47.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Sep 2019 23:47:01 -0700 (PDT) To: Hideyuki Yamashita , x-fn-spp@sl.ntt-tx.co.jp From: Yasufumi Ogawa Cc: dpdk-spp Message-ID: <5cb48b3f-7b69-9c8e-66ee-84e04a03487b@gmail.com> Date: Wed, 11 Sep 2019 15:46:58 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: [spp] Failed to init ring_latency_stats_info X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" Hi Hideyuki, I have a problem in initializing SPP ringlatencystats. rte_zmalloc() in spp_ringlatencystats_init() returns NULL and process is terminated with log as below. ... SPP_RING_LATENCY_STATS: Cannot allocate memory for ring latency stats info SPP_VF: Exit spp_vf I made some changes to this file for refactoring, but it might not related to the error from `git blame`. It is simply calling rte_zmalloc() with sizeof() and I cannot understand why error is happened. spp_ringlatencystats_init(uint64_t samp_intvl, uint16_t stats_count) { /* allocate memory for ring latency statistics information */ g_stats_info = rte_zmalloc( "global ring_latency_stats_info", sizeof(struct ring_latency_stats_info) * stats_count, 0); if (unlikely(g_stats_info == NULL)) { RTE_LOG(ERR, SPP_RING_LATENCY_STATS, "Cannot allocate memory " "for ring latency stats info\n"); return SPPWK_RET_NG; } Although ringlatencystats is not activated by default and almost no one use, it should be fixed. Thanks, Yasufumi