From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mogw0813.ocn.ad.jp (mogw0813.ocn.ad.jp [153.149.234.14]) by dpdk.org (Postfix) with ESMTP id 4DC8B5F24 for ; Sat, 24 Nov 2018 14:15:17 +0100 (CET) Received: from mf-smf-unw003c1 (mf-smf-unw003c1.ocn.ad.jp [153.138.219.72]) by mogw0813.ocn.ad.jp (Postfix) with ESMTP id 3151420027E; Sat, 24 Nov 2018 22:15:16 +0900 (JST) Received: from ocn-vc-mts-202c1.ocn.ad.jp ([153.138.219.215]) by mf-smf-unw003c1 with ESMTP id QXlXg9x2Y2gjgQXmGg2bIy; Sat, 24 Nov 2018 22:15:16 +0900 Received: from smtp.ocn.ne.jp ([153.149.227.167]) by ocn-vc-mts-202c1.ocn.ad.jp with ESMTP id QXmFgLzeGVBnyQXmFgyxms; Sat, 24 Nov 2018 22:15:16 +0900 Received: from mugwort.local (p3371093-ipngn19601marunouchi.tokyo.ocn.ne.jp [153.228.164.93]) by smtp.ocn.ne.jp (Postfix) with ESMTPA; Sat, 24 Nov 2018 22:15:15 +0900 (JST) To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, ogawa.yasufumi@lab.ntt.co.jp, spp@dpdk.org References: <201811210135.wAL1ZxN9009578@imss03.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <5f60a3cc-3515-6ba7-2150-03863c702e3f@juno.ocn.ne.jp> Date: Sat, 24 Nov 2018 22:15:15 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201811210135.wAL1ZxN9009578@imss03.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH 00/23] move some codes of spp_vf into vf/common X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Nov 2018 13:15:18 -0000 > Some spp_vf codes can be used by new secondary process which > is extended from spp_vf. This patch set move such codes into > spp_vf/common. Hideyuki, Your update of `spp_convert_component_type()` in `command_dec.c` has a problem because `type_str` variable is only used in `ifdef` preprocessor directive and it is considered as not used by compiler. It causes a compile error, so should be fixed. I fixed this error by adding RTE_LOG() outside the preprocessor directive to avoid the error as following. I would like send patch if it is agreeable. RTE_LOG(DEBUG, APP, "type_str is %s\n", type_str); Thanks, Yasufumi > > Hideyuki Yamashita (23): > spp_vf: fix invalid code for max chars > spp_vf: move common source and header files > spp_vf: change include path > spp_vf: update Makefile for common files > spp_vf: move functions to common directory > spp_vf: move defines to common dir > spp_vf: move functions for decode to common dir > spp_vf: move defines for decode to common dir > spp_vf: move functions to command_proc.c > spp_vf: add management data registration > spp_vf: change reference of management data > spp_vf: change return values to explain result > spp_vf: define terms of commands as consts > spp_vf: remove unnecessary includes > spp_vf: add include header files > spp_vf: update comments for header file > spp_vf: update makefile of spp_vf > spp_vf: add check num of ports before forwarding > spp_vf: add flag for classifier table > spp_vf: add checking the number of ports > spp_vf: add vlantag command check flag > spp_vf: simplify changing VLAN tag > spp_vf: add SPP_VF_MODULE preprocessor directive > > src/vf/Makefile | 7 +- > src/vf/classifier_mac.c | 139 ++- > src/vf/classifier_mac.h | 20 +- > src/vf/{ => common}/command_conn.c | 23 +- > src/vf/{ => common}/command_conn.h | 16 +- > src/vf/{ => common}/command_dec.c | 641 +++++++--- > src/vf/{ => common}/command_dec.h | 21 +- > src/vf/{ => common}/command_proc.c | 716 +++++++++-- > src/vf/{ => common}/command_proc.h | 10 +- > src/vf/{ => common}/ringlatencystats.c | 15 +- > src/vf/{ => common}/ringlatencystats.h | 4 +- > src/vf/{ => common}/spp_port.c | 34 +- > src/vf/{ => common}/spp_port.h | 2 +- > src/vf/common/spp_proc.c | 1029 ++++++++++++++++ > src/vf/common/spp_proc.h | 727 +++++++++++ > src/vf/{ => common}/string_buffer.c | 3 +- > src/vf/{ => common}/string_buffer.h | 0 > src/vf/spp_forward.c | 47 +- > src/vf/spp_forward.h | 12 +- > src/vf/spp_vf.c | 1574 +----------------------- > src/vf/spp_vf.h | 511 -------- > 21 files changed, 3074 insertions(+), 2477 deletions(-) > rename src/vf/{ => common}/command_conn.c (90%) > rename src/vf/{ => common}/command_conn.h (82%) > rename src/vf/{ => common}/command_dec.c (53%) > rename src/vf/{ => common}/command_dec.h (90%) > rename src/vf/{ => common}/command_proc.c (63%) > rename src/vf/{ => common}/command_proc.h (80%) > rename src/vf/{ => common}/ringlatencystats.c (92%) > rename src/vf/{ => common}/ringlatencystats.h (97%) > rename src/vf/{ => common}/spp_port.c (94%) > rename src/vf/{ => common}/spp_port.h (99%) > create mode 100644 src/vf/common/spp_proc.c > create mode 100644 src/vf/common/spp_proc.h > rename src/vf/{ => common}/string_buffer.c (97%) > rename src/vf/{ => common}/string_buffer.h (100%) >