Re: [spp] [PATCH 1/9] spp_vf: refactor to comply with coding rule

[Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>]

On 2018/02/08 14:51, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Kentaro Watanabe <watanabe.kentaro.z01@as.ntt-tx.co.jp>
> 
> Hi, all
> 
>> Hi everyone,
>>
>> As announced in DPDK Summit, we would like to introduce a SR-IOV like network
>> functionality to SPP on DPDK17.08[1].
> <snip>
>> Limitaion#1: vlan support is not yet, this feature is in still our backlogs.
> 
> Following patches enables spp_vf to support vlan feature.
> 
> On 2017/12/28 13:55, x-fn-spp@sl.ntt-tx.co.jp wrote:
>> From: Hiroyuki Nakamura <nakamura.hioryuki@po.ntt-tx.co.jp>
>>> Hi everyone,
>>> This the first patch of series for spp_vf. Some of them might not comply
>> with coding style for whitespace or indenting and I would like to send
>> patches to fix it later.
>>> I also would like to send another series of patches for documentation after
>> you accept first series.
> 
> Above coding style violation is also fixed.
> 
> On 2018/02/08 1:50, Ferruh Yigit wrote:
>> On 12/28/2017 4:55 AM, x-fn-spp@sl.ntt-tx.co.jp wrote:
>>> From: Hiroyuki Nakamura <nakamura.hioryuki@po.ntt-tx.co.jp>
>>>
> <snip>
>>> Hi Daiki, Yasufum,
>>> This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this
>> release.
> 
> To support latest dpdk, "RTE_LOG_LEVEL" is removed.
> 
> Thanks,
> 
Hi, Kentaro

Thanks for your contribution! I confirmed that it is compiled with the
latest DPDK successfully and source codes are cleaned up well.

Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

> 
> * Fixed warnings etc. in checkpatch.sh of DPDK.
> * Change tab to space except indent tab.
> 
> Signed-off-by: Kentaro Watanabe <watanabe.kentaro.z01@as.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
>   src/vf/Makefile           |   2 +-
>   src/vf/classifier_mac.c   | 267 ++++++++++++++++++++++++++++------------------
>   src/vf/command_conn.c     |  26 ++---
>   src/vf/command_conn.h     |   8 +-
>   src/vf/command_dec.c      | 189 ++++++++++++++++++++------------
>   src/vf/command_dec.h      |  12 ++-
>   src/vf/command_proc.c     |  61 +++++++----
>   src/vf/command_proc.h     |   4 +-
>   src/vf/ringlatencystats.c |  37 ++++---
>   src/vf/ringlatencystats.h |  11 +-
>   src/vf/spp_forward.c      |  30 ++++--
>   src/vf/spp_vf.c           | 239 +++++++++++++++++++++--------------------
>   src/vf/spp_vf.h           |  36 +++----
>   src/vf/string_buffer.c    |   4 +-
>   src/vf/string_buffer.h    |  15 ++-
>   15 files changed, 547 insertions(+), 394 deletions(-)