From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 41E671B765 for ; Thu, 8 Feb 2018 08:46:46 +0100 (CET) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w187kji7029848; Thu, 8 Feb 2018 16:46:45 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 50DBEEA705B; Thu, 8 Feb 2018 16:46:45 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 46903EA813E; Thu, 8 Feb 2018 16:46:45 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 3D3644006C6; Thu, 8 Feb 2018 16:46:45 +0900 (JST) References: <201802080551.w185pkLL010335@imss03.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <60d08dbc-dafd-e605-e0dd-6a54530d3fc0@lab.ntt.co.jp> Date: Thu, 8 Feb 2018 16:45:31 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201802080551.w185pkLL010335@imss03.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp, spp@dpdk.org, ferruh.yigit@intel.com X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 1/9] spp_vf: refactor to comply with coding rule X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 07:46:47 -0000 On 2018/02/08 14:51, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Kentaro Watanabe > > Hi, all > >> Hi everyone, >> >> As announced in DPDK Summit, we would like to introduce a SR-IOV like network >> functionality to SPP on DPDK17.08[1]. > >> Limitaion#1: vlan support is not yet, this feature is in still our backlogs. > > Following patches enables spp_vf to support vlan feature. > > On 2017/12/28 13:55, x-fn-spp@sl.ntt-tx.co.jp wrote: >> From: Hiroyuki Nakamura >>> Hi everyone, >>> This the first patch of series for spp_vf. Some of them might not comply >> with coding style for whitespace or indenting and I would like to send >> patches to fix it later. >>> I also would like to send another series of patches for documentation after >> you accept first series. > > Above coding style violation is also fixed. > > On 2018/02/08 1:50, Ferruh Yigit wrote: >> On 12/28/2017 4:55 AM, x-fn-spp@sl.ntt-tx.co.jp wrote: >>> From: Hiroyuki Nakamura >>> > >>> Hi Daiki, Yasufum, >>> This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this >> release. > > To support latest dpdk, "RTE_LOG_LEVEL" is removed. > > Thanks, > Hi, Kentaro Thanks for your contribution! I confirmed that it is compiled with the latest DPDK successfully and source codes are cleaned up well. Acked-by: Yasufumi Ogawa > > * Fixed warnings etc. in checkpatch.sh of DPDK. > * Change tab to space except indent tab. > > Signed-off-by: Kentaro Watanabe > Signed-off-by: Naoki Takada > --- > src/vf/Makefile | 2 +- > src/vf/classifier_mac.c | 267 ++++++++++++++++++++++++++++------------------ > src/vf/command_conn.c | 26 ++--- > src/vf/command_conn.h | 8 +- > src/vf/command_dec.c | 189 ++++++++++++++++++++------------ > src/vf/command_dec.h | 12 ++- > src/vf/command_proc.c | 61 +++++++---- > src/vf/command_proc.h | 4 +- > src/vf/ringlatencystats.c | 37 ++++--- > src/vf/ringlatencystats.h | 11 +- > src/vf/spp_forward.c | 30 ++++-- > src/vf/spp_vf.c | 239 +++++++++++++++++++++-------------------- > src/vf/spp_vf.h | 36 +++---- > src/vf/string_buffer.c | 4 +- > src/vf/string_buffer.h | 15 ++- > 15 files changed, 547 insertions(+), 394 deletions(-)