From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id D9C265F32 for ; Wed, 13 Feb 2019 08:26:13 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x1D7QC0a008318; Wed, 13 Feb 2019 16:26:12 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 422DB638E12; Wed, 13 Feb 2019 16:26:12 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 2A7B2638DCA; Wed, 13 Feb 2019 16:26:12 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 14E0A40065A; Wed, 13 Feb 2019 16:26:12 +0900 (JST) References: <201902080451.x184pi5d029831@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: <72ebeabc-a48c-e7de-365d-f3678fca9dc0@lab.ntt.co.jp> Date: Wed, 13 Feb 2019 16:23:58 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201902080451.x184pi5d029831@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 1/1] docs: add core sharing usage in spp_vf command ref X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 07:26:14 -0000 On 2019/02/08 13:51, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hideyuki Yamashita > > This patch adds how to assign more than one component on the same core > in component command of spp_vf into command reference. > > This patch also fixes typos. Applied, thanks. > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > --- > docs/guides/commands/secondary/spp_vf.rst | 23 +++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/docs/guides/commands/secondary/spp_vf.rst b/docs/guides/commands/secondary/spp_vf.rst > index 3cf1cca..6f1824b 100644 > --- a/docs/guides/commands/secondary/spp_vf.rst > +++ b/docs/guides/commands/secondary/spp_vf.rst > @@ -6,7 +6,7 @@ > spp_vf > ====== > > -``spp_vf`` is a kind of SPP secondary process. It it introduced for > +``spp_vf`` is a kind of SPP secondary process. It is introduced for > providing SR-IOV like features. > > Each of ``spp_vf`` processes is managed with ``vf`` command. It is for > @@ -136,7 +136,7 @@ assigned to this thread. > ``Components`` is a list of all of worker threads. Each of workers has a > core ID running on, type of the worker and a list of resources. > Entry of no name with ``unuse`` type means that no worker thread assigned to > -the core. In other words, it is ready to be assinged. > +the core. In other words, it is ready to be assigned. > > > .. _commands_spp_vf_component: > @@ -144,7 +144,7 @@ the core. In other words, it is ready to be assinged. > component > --------- > > -Assing or release a role of forwarding to worker threads running on each of > +Assign or release a role of forwarding to worker threads running on each of > cores which are reserved with ``-c`` or ``-l`` option while launching > ``spp_vf``. The role of the worker is chosen from ``forward``, ``merge`` or > ``classifier_mac``. > @@ -165,7 +165,7 @@ This name is also used while releasing the role. > # release worker 'NAME' from the role > spp > vf SEC_ID; component stop NAME > > -Here is some examples of assigning roles with ``component`` command. > +Here are some examples of assigning roles with ``component`` command. > > .. code-block:: console > > @@ -178,7 +178,18 @@ Here is some examples of assigning roles with ``component`` command. > # assign 'classifier_mac' role with name 'cls1' on core 4 > spp > vf 2; component start cls1 4 classifier_mac > > -Or examples of releasing roles. > +In the above examples, each different ``CORE-ID`` is specified to each role. > +You can assign several components on the same core, but performance might be > +decreased. This is an example for assigning two roles of ``forward`` and > +``merge`` on the same ``core 2``. > + > +.. code-block:: console > + > + # assign two roles on the same 'core 2'. > + spp > vf 2; component start fw1 2 forward > + spp > vf 2; component start mgr1 2 merge > + > +Examples of releasing roles. > > .. code-block:: console > > @@ -340,7 +351,7 @@ Here is an example for adding entries. > # add entry of default with VLAN tag > spp > vf 1; classifier_table add vlan 101 default ring:1 > > -Delete an entryThis is an example to delete an entry for port ``ring:0``. > +Delete an entry. This is an example to delete an entry with VLAN tag 101. > > .. code-block:: console > > -- Yasufumi Ogawa NTT Network Service Systems Labs