[spp] [PATCH] version: 18.02-rc3

[spp] [PATCH] version: 18.02-rc3

[ogawa.yasufumi]

From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

Fix compile error for updating v18.02. This version of SPP is checked
for compile with DPDK 18.02-rc3.

Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index abef16b..e659798 100644
--- a/Makefile
+++ b/Makefile
@@ -29,7 +29,7 @@
 #   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-VERSION = 17.11
+VERSION = 18.02-rc3
 
 ifeq ($(RTE_SDK),)
 $(error "Please define RTE_SDK environment variable")
-- 
2.7.4

Re: [spp] [PATCH] version: 18.02-rc3

[Ferruh Yigit]

On 2/8/2018 3:18 PM, ogawa.yasufumi@lab.ntt.co.jp wrote:
> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> 
> Fix compile error for updating v18.02. This version of SPP is checked
> for compile with DPDK 18.02-rc3.
> 
> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index abef16b..e659798 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -29,7 +29,7 @@
>  #   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>  #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>  
> -VERSION = 17.11
> +VERSION = 18.02-rc3

Hi Yasufumi,

I think it is not required to version for DPDK -rcX releases.
We can do this when v18.02 released, which is a few days away.

But I believe it makes sense to fix build errors seen against dpdk master, and
for this specific case it can be fixed in a way that works fine with both v17.11
and dpdk master.

>  
>  ifeq ($(RTE_SDK),)
>  $(error "Please define RTE_SDK environment variable")
> 

Re: [spp] [PATCH] version: 18.02-rc3

[Yasufumi Ogawa]

On 2018/02/09 0:31, Ferruh Yigit wrote:
> On 2/8/2018 3:18 PM, ogawa.yasufumi@lab.ntt.co.jp wrote:
>> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>>
>> Fix compile error for updating v18.02. This version of SPP is checked
>> for compile with DPDK 18.02-rc3.
>>
>> Signed-off-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>> ---
>>   Makefile | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index abef16b..e659798 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -29,7 +29,7 @@
>>   #   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>>   #   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>>   
>> -VERSION = 17.11
>> +VERSION = 18.02-rc3
> 
> Hi Yasufumi,
> 
> I think it is not required to version for DPDK -rcX releases.
> We can do this when v18.02 released, which is a few days away.
> 
> But I believe it makes sense to fix build errors seen against dpdk master, and
> for this specific case it can be fixed in a way that works fine with both v17.11
> and dpdk master.

Hi Ferruh,

OK. I'd not like to update for rc versions. As you mentioned, it is more 
simple and enough just keeping compatibility with latest DPDK and do not 
update SPP version. Could you discard this patch?

Thanks

> 
>>   
>>   ifeq ($(RTE_SDK),)
>>   $(error "Please define RTE_SDK environment variable")
>>
> 
> 
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs