From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 138111B887 for ; Fri, 9 Feb 2018 03:06:07 +0100 (CET) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w19266dw021841; Fri, 9 Feb 2018 11:06:06 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 6980FEA7577; Fri, 9 Feb 2018 11:06:06 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 5F07BEA6F6E; Fri, 9 Feb 2018 11:06:06 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 5531C4007DC; Fri, 9 Feb 2018 11:06:06 +0900 (JST) References: <1518103102-4679-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> <4d2fa69b-cbcc-92bc-3f21-7113e6f6d50c@intel.com> From: Yasufumi Ogawa Message-ID: <7c3e4684-a7cb-d121-9097-c69446748136@lab.ntt.co.jp> Date: Fri, 9 Feb 2018 11:04:52 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4d2fa69b-cbcc-92bc-3f21-7113e6f6d50c@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Ferruh Yigit , spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH] version: 18.02-rc3 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Feb 2018 02:06:08 -0000 On 2018/02/09 0:31, Ferruh Yigit wrote: > On 2/8/2018 3:18 PM, ogawa.yasufumi@lab.ntt.co.jp wrote: >> From: Yasufumi Ogawa >> >> Fix compile error for updating v18.02. This version of SPP is checked >> for compile with DPDK 18.02-rc3. >> >> Signed-off-by: Yasufumi Ogawa >> --- >> Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Makefile b/Makefile >> index abef16b..e659798 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -29,7 +29,7 @@ >> # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE >> # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> >> -VERSION = 17.11 >> +VERSION = 18.02-rc3 > > Hi Yasufumi, > > I think it is not required to version for DPDK -rcX releases. > We can do this when v18.02 released, which is a few days away. > > But I believe it makes sense to fix build errors seen against dpdk master, and > for this specific case it can be fixed in a way that works fine with both v17.11 > and dpdk master. Hi Ferruh, OK. I'd not like to update for rc versions. As you mentioned, it is more simple and enough just keeping compatibility with latest DPDK and do not update SPP version. Could you discard this patch? Thanks > >> >> ifeq ($(RTE_SDK),) >> $(error "Please define RTE_SDK environment variable") >> > > > -- Yasufumi Ogawa NTT Network Service Systems Labs