From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ogawa.yasufumi@lab.ntt.co.jp>
Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147])
 by dpdk.org (Postfix) with ESMTP id D5F564C96
 for <spp@dpdk.org>; Tue, 25 Sep 2018 10:38:00 +0200 (CEST)
Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])
 by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w8P8bxcZ012655;
 Tue, 25 Sep 2018 17:37:59 +0900
Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])
 by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id ABA0E6391FA;
 Tue, 25 Sep 2018 17:37:59 +0900 (JST)
Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp
 [129.60.87.134])
 by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 9FF086390E5;
 Tue, 25 Sep 2018 17:37:59 +0900 (JST)
Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73])
 by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 9A972400821;
 Tue, 25 Sep 2018 17:37:59 +0900 (JST)
References: <201809210417.w8L4H25D018075@imss03.silk.ntt-tx.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Message-ID: <89e07979-dd7f-e999-f862-acb6c71ac706@lab.ntt.co.jp>
Date: Tue, 25 Sep 2018 17:35:54 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <201809210417.w8L4H25D018075@imss03.silk.ntt-tx.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CC-Mail-RelayStamp: 1
To: x-fn-spp@sl.ntt-tx.co.jp
Cc: ferruh.yigit@intel.com, spp@dpdk.org
X-TM-AS-MML: disable
Subject: Re: [spp] [PATCH] docs: update qemu-ifup
X-BeenThere: spp@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Soft Patch Panel <spp.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/spp>,
 <mailto:spp-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/spp/>
List-Post: <mailto:spp@dpdk.org>
List-Help: <mailto:spp-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/spp>,
 <mailto:spp-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Sep 2018 08:38:01 -0000

> From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> 
> To fix errors in `qemu-ifup`, remove the first erroneous line and
> correct the paths of tunctl and brctl for Ubuntu's apt.
> 
Thanks!

Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
>   docs/samples/qemu-ifup | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/samples/qemu-ifup b/docs/samples/qemu-ifup
> index 4538b65..8fbf700 100755
> --- a/docs/samples/qemu-ifup
> +++ b/docs/samples/qemu-ifup
> @@ -1,14 +1,13 @@
> -vi /etc/qemu-ifup
>   #!/bin/sh
>   set -x
>   
>   switch=virbr0
>   
>   if [ -n "$1" ];then
> -        /usr/bin/sudo /usr/sbin/tunctl -u `whoami` -t $1
> +        /usr/bin/sudo /usr/bin/tunctl -u `whoami` -t $1
>           /usr/bin/sudo /sbin/ip link set $1 up
>           sleep 0.5s
> -        /usr/bin/sudo /usr/sbin/brctl addif $switch $1
> +        /usr/bin/sudo /sbin/brctl addif $switch $1
>           exit 0
>   else
>           echo "Error: no interface specified"
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs