From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>, x-fn-spp@sl.ntt-tx.co.jp
Cc: spp@dpdk.org
Subject: Re: [spp] [PATCH] spp_vf: fix unexpected tx port is shown in status
Date: Wed, 22 Aug 2018 10:37:43 +0100 [thread overview]
Message-ID: <94a0cc91-0bd1-7036-75d9-6e762428ee18@intel.com> (raw)
In-Reply-To: <6524128b-0907-ec85-5133-cc77a407c50c@lab.ntt.co.jp>
On 8/9/2018 3:24 AM, Yasufumi Ogawa wrote:
> On 2018/07/30 14:10, x-fn-spp@sl.ntt-tx.co.jp wrote:
>> From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
>>
>> Unexpected tx port is shown without adding it because of bug of status
>> command. Here is an example.
>>
>> spp > sec 1;component start fwd1 12 forward
>> spp > sec 1;port add ring:0 rx fwd1
>> spp > sec 1;flush
>> spp > sec 1;status
>> { "results": [ { "result": "success" } ],"info": { "client-id": 2,
>> ...
>> "tx_port": [ { "port": "phy:0", "vlan": { "operation": # Here
>> ...
>>
>> It is because status command wrongly assumes the number of tx port is
>> equal to rx if the number of rx port is greater than zero. To fix the
>> problem, add 'num_tx' in struct forward_path to hold the number exactly.
> Thanks for your update.
>
> Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Applied, thanks.
prev parent reply other threads:[~2018-08-22 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 5:10 x-fn-spp
2018-08-09 2:24 ` Yasufumi Ogawa
2018-08-22 9:37 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0cc91-0bd1-7036-75d9-6e762428ee18@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).