From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 5DD1B1B756
 for <spp@dpdk.org>; Wed,  7 Feb 2018 17:50:59 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 07 Feb 2018 08:50:58 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,473,1511856000"; d="scan'208";a="25639295"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91])
 ([10.237.220.91])
 by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2018 08:50:57 -0800
To: x-fn-spp@sl.ntt-tx.co.jp, spp@dpdk.org
References: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp>
 <201712280456.vBS4u46q010906@imss03.silk.ntt-tx.co.jp>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9fb4b932-bf15-2e19-b4d7-5cb19694eb9e@intel.com>
Date: Wed, 7 Feb 2018 16:50:56 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <201712280456.vBS4u46q010906@imss03.silk.ntt-tx.co.jp>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [spp] [PATCH 02/57] spp_vf: support multi process
X-BeenThere: spp@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Soft Patch Panel <spp.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/spp>,
 <mailto:spp-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/spp/>
List-Post: <mailto:spp@dpdk.org>
List-Help: <mailto:spp-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/spp>,
 <mailto:spp-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Feb 2018 16:50:59 -0000

On 12/28/2017 4:55 AM, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hioryuki@po.ntt-tx.co.jp>
> 
> spp_vf was only a single process so far, but spp_vf supported
> multi process. Following modification has been made.
> 
> * Change naming machanism to allow hashtable on shared memory
>   to be operated by multiple processes.
> * Get config file path from command line argument.
> 
> And following modification has been made.
> * Modify comment.
> * Add and modify log message.
> * Add function to remove vhost socket file.
> 
> Signed-off-by: Daiki Yamashita <yamashita.daiki.z01@as.ntt-tx.co.jp>
> Signed-off-by: Yasufum Ogawa <ogawa.yasufumi@lab.ntt.co.jp>

<...>

> @@ -669,6 +732,24 @@ print_ring_latency_stats()
>  #endif /* SPP_RINGLATENCYSTATS_ENABLE */
>  
>  /*
> + * VHOST用ソケットファイル削除
> + */
> +static void
> +del_vhost_sockfile(struct patch_info *vhost_patchs)
> +{
> +	int cnt;
> +	for (cnt = 0; cnt < RTE_MAX_ETHPORTS; cnt++) {
> +		if (likely(vhost_patchs[cnt].use_flg == 0)) {
> +			/* VHOST未使用はスキップ */
> +			continue;
> +		}
> +
> +		/* 使用していたVHOSTについて削除を行う */

Would you mind translating comments to English. It helps if code understood by
more people.

<...>

>  		}
> +
> +		/* Skip dpdk parameters */
> +		argc -= ret_dpdk;
> +		argv += ret_dpdk;
> +
> +		/* Set log level  */
> +		rte_log_set_global_level(RTE_LOG_LEVEL);

Hi Daiki, Yasufum,

This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this
release.

Can you please check this?