Re: [spp] [PATCH 2/7] spp_primary: convert license to SPDX tag

[Trishan de Lanerolle <tdelanerolle@linuxfoundation.org>]

Hi,
Thanks for bringing up the question. Generally, we recommend that SPDX
license identifiers -- for existing files be thought as supplemental
information to add. Don't replace the existing license information, add the
tags on.  Suggest reviewing the patch against that criteria.  Remember to
maintain the attribution information. You may want to speak to your
in-house counsel with respect to any changes you would like to make to
files over which you hold copyright.

Regards,
Trishan


On Wed, May 16, 2018 at 5:08 AM, Yasufumi Ogawa <
ogawa.yasufumi@lab.ntt.co.jp> wrote:

> On 2018/05/16 1:55, Ferruh Yigit wrote:
>
>> On 5/3/2018 5:08 PM, Ferruh Yigit wrote:
>>
>>> On 4/23/2018 7:28 AM, ogawa.yasufumi@lab.ntt.co.jp wrote:
>>>
>>>> @@ -1,34 +1,6 @@
>>>> -/*-
>>>> - *   BSD LICENSE
>>>> - *
>>>> - *   Copyright(c) 2015-2016 Intel Corporation. All rights reserved.
>>>> - *   All rights reserved.
>>>> - *
>>>> - *   Redistribution and use in source and binary forms, with or without
>>>> - *   modification, are permitted provided that the following conditions
>>>> - *   are met:
>>>> - *
>>>> - *     * Redistributions of source code must retain the above copyright
>>>> - *       notice, this list of conditions and the following disclaimer.
>>>> - *     * Redistributions in binary form must reproduce the above
>>>> copyright
>>>> - *       notice, this list of conditions and the following disclaimer
>>>> in
>>>> - *       the documentation and/or other materials provided with the
>>>> - *       distribution.
>>>> - *     * Neither the name of Intel Corporation nor the names of its
>>>> - *       contributors may be used to endorse or promote products
>>>> derived
>>>> - *       from this software without specific prior written permission.
>>>> - *
>>>> - *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
>>>> CONTRIBUTORS
>>>> - *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
>>>> - *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
>>>> FOR
>>>> - *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
>>>> COPYRIGHT
>>>> - *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
>>>> INCIDENTAL,
>>>> - *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
>>>> - *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF
>>>> USE,
>>>> - *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
>>>> ANY
>>>> - *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
>>>> TORT
>>>> - *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
>>>> USE
>>>> - *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
>>>> DAMAGE.
>>>> +/* SPDX-License-Identifier: BSD-3-Clause
>>>> + * Copyright(c) 2015-2016 Intel Corporation
>>>> + * Copyright(c) 2017-2018 Nippon Telegraph and Telephone Corporation
>>>>    */
>>>>
>>>
>>> Hi Ogawa-san,
>>>
>>> Thanks for taking initiative to switch spp to SPDX, appreciated.
>>>
>>> First Trishan from Linux foundation and Jim from DPDK governance board
>>> are cc'ed
>>> for input if there is any concern or more process to follow from
>>> governance
>>> point of view.
>>>
>>
>> The is no response, which I am taking as there is no concern and will move
>> forward on getting patches. Please shout if there are concerns.
>>
> Hi Trishan, Jim,
>
> SPP was provided originally from Intel, but currently is maintained by NTT
> and planed to change license to SPDX. We have made many changes on SPP and
> I would like to add NTT to the license only for considerably modified or
> newly created files by NTT. Could you give us advice if there are any
> concern?
>
> Thanks,
> Yasufumi
>
>
>>
>>> Second these patches are both converts licensing to SPDX tag and adds
>>> ntt as
>>> copyright holder. Can we separate these two please? A patchset to convert
>>> existing licensing to SPDX as it is, and another set to add ntt.
>>>
>>>
>>> Thanks,
>>> ferruh
>>>
>>>
>>
>>
>>
>
> --
> Yasufumi Ogawa
> NTT Network Service Systems Labs
>
>


-- 
Trishan R. de Lanerolle
Program Manager,  Networking
Linux Foundation
voice: +1.203.699.6401
skype: tdelanerolle
email: tdelanerolle@linuxfoundation.org