From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 80DC01B3B6 for ; Thu, 29 Nov 2018 02:38:52 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wAT1co73012070; Thu, 29 Nov 2018 10:38:50 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id CA9B4638AE0; Thu, 29 Nov 2018 10:38:50 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id BF42D637271; Thu, 29 Nov 2018 10:38:50 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id BA8D84008D5; Thu, 29 Nov 2018 10:38:50 +0900 (JST) References: <20181129005512.18526-1-oda@valinux.co.jp> From: Yasufumi Ogawa Message-ID: Date: Thu, 29 Nov 2018 10:36:21 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20181129005512.18526-1-oda@valinux.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: oda@valinux.co.jp Cc: spp@dpdk.org, ferruh.yigit@intel.com X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 0/2] spp_mirror API support X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 01:38:53 -0000 > As new process spp_mirror is introduced, spp-ctl supports > its API. Hi Itsuro, Thank you for your update quickly. Your patches are looks good, but titles of commit messages are inappropriate. Could you revise them for v2 patches as following if you agree? spp-ctl: add spp_mirror API support docs: add spp_mirror API api-reference Thanks, Yasufumi > > Itsuro Oda (2): > spp_mirror API support > spp_mirror API api-reference > > docs/guides/spp-ctl/api-reference.rst | 316 ++++++++++++++++++++++++++ > src/spp-ctl/spp_ctl.py | 2 +- > src/spp-ctl/spp_proc.py | 57 +++-- > src/spp-ctl/spp_webapi.py | 120 +++++++--- > 4 files changed, 443 insertions(+), 52 deletions(-)