From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>, x-fn-spp@sl.ntt-tx.co.jp
Cc: spp@dpdk.org
Subject: Re: [spp] [PATCH v3] spp_vf: fix initializing bug of forwarder
Date: Wed, 22 Aug 2018 10:42:01 +0100 [thread overview]
Message-ID: <a219eb94-b707-b5e8-d76b-ebc71402f111@intel.com> (raw)
In-Reply-To: <c201ce14-6ff2-674c-b12e-b896391818da@lab.ntt.co.jp>
On 8/9/2018 5:25 AM, Yasufumi Ogawa wrote:
>> From: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
>>
>> clear_forward_info() always initializes path[0] of g_forward_info[id].
>> It is a bug and causes stopping forwarding accidentally if path[0] is
>> referenced by spp_forward().
>>
>> This patch changes initializing as path[info->upd_index] instead of 0.
>> It also includes following refactoring
>> - using local vars to be simple
>> - replace clear_forward_info() by memset
> Thanks!
>
> Acked-by: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>>
>> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@po.ntt-tx.co.jp>
>> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
Applied, thanks.
prev parent reply other threads:[~2018-08-22 9:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 8:31 [spp] [PATCH] " x-fn-spp
2018-08-07 4:13 ` Yasufumi Ogawa
2018-08-07 6:31 ` [spp] [spp 03176] " Hideyuki Yamashita
2018-08-07 6:57 ` Yasufumi Ogawa
2018-08-08 5:34 ` [spp] [spp 03180] " Hideyuki Yamashita
2018-08-09 0:38 ` [spp] [PATCH v2 1/1] " x-fn-spp
2018-08-09 2:43 ` Yasufumi Ogawa
2018-08-09 4:06 ` [spp] [PATCH v3] " x-fn-spp
2018-08-09 4:25 ` Yasufumi Ogawa
2018-08-22 9:42 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a219eb94-b707-b5e8-d76b-ebc71402f111@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).