From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 2A0941B3A6 for ; Tue, 25 Dec 2018 08:49:24 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wBP7nNxW029587; Tue, 25 Dec 2018 16:49:23 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id D83A6638D48; Tue, 25 Dec 2018 16:49:23 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id CCEB3638D1F; Tue, 25 Dec 2018 16:49:23 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id C8055400CBC; Tue, 25 Dec 2018 16:49:23 +0900 (JST) References: <201812210623.wBL6NiXF008245@imss03.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Tue, 25 Dec 2018 16:46:55 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201812210623.wBL6NiXF008245@imss03.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH] spp_vf: change exit command to return response X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2018 07:49:25 -0000 > From: Hideyuki Yamashita > > For secondary processes use common process_request(), it causes an > error because spp-ctl expects a response but these processes do not > return anything. This patch is to change it to return message. Applied, thanks. > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > --- > src/vf/common/command_proc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/vf/common/command_proc.c b/src/vf/common/command_proc.c > index cf35ce0..a612061 100644 > --- a/src/vf/common/command_proc.c > +++ b/src/vf/common/command_proc.c > @@ -1600,8 +1600,10 @@ process_request(int *sock, const char *request_str, size_t request_str_len) > if (request.is_requested_exit) { > /* Terminated by process exit command. */ > /* Other route is normal end because it responds to command. */ > + set_command_results(&command_results[0], CRES_SUCCESS, ""); > + send_command_result_response(sock, &request, command_results); > RTE_LOG(INFO, SPP_COMMAND_PROC, > - "No response with process exit command.\n"); > + "Terminate process for exit.\n"); > return SPP_RET_NG; > } > >