From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
To: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com
Cc: spp@dpdk.org
Subject: Re: [spp] [PATCH 2/3] docs: correct incorrect SPP git URL
Date: Fri, 15 Jun 2018 11:58:04 +0900 [thread overview]
Message-ID: <abd9ccd9-f89a-8cad-3776-019db15bef05@lab.ntt.co.jp> (raw)
In-Reply-To: <201806080901.w5891qj7010253@imss04.silk.ntt-tx.co.jp>
On 2018/06/08 18:01, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
>
> This commit correct incorrect SPP git URL.
>
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
> docs/guides/spp_vf/gsg/build.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
> index 93132d4..e7a2a17 100644
> --- a/docs/guides/spp_vf/gsg/build.rst
> +++ b/docs/guides/spp_vf/gsg/build.rst
> @@ -136,8 +136,8 @@ Clone SPP in any directory and compile it.
> .. code-block:: console
>
> $ cd /path/to/spp_home/
I think that users may be confused for what is 'spp_home' and where is it. You should add an explanation about it if you need to
move to 'spp_home' dir.
> - $ git clone https://github.com/ntt-ns/Soft-Patch-Panel.git
> - export SPP_HOME=/path/to/spp_home/Soft-Patch-Panel
> + $ git clone http://dpdk.org/git/apps/spp
> + $ export SPP_HOME=/path/to/spp_home/spp
I think it is no good naming because 'spp_home' is not '$SPP_HOME'. Could you change it to be consistent?
Thanks,
> $ cd $SPP_HOME
> $ make
>
>
--
Yasufumi Ogawa
NTT Network Service Systems Labs
next prev parent reply other threads:[~2018-06-15 3:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1528448512-21000-1-git-send-email-x-fn-spp@sl.ntt-tx.co.jp>
2018-06-08 9:01 ` [spp] [PATCH 1/3] docs: add how to install qemu 2.7 x-fn-spp
2018-06-11 1:22 ` Yasufumi Ogawa
2018-06-08 9:01 ` [spp] [PATCH 2/3] docs: correct incorrect SPP git URL x-fn-spp
2018-06-11 1:27 ` Yasufumi Ogawa
2018-06-15 2:58 ` Yasufumi Ogawa [this message]
2018-06-08 9:01 ` [spp] [PATCH 3/3] docs:delete unsupported SPP VF Secondary Command x-fn-spp
2018-06-11 1:36 ` Yasufumi Ogawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abd9ccd9-f89a-8cad-3776-019db15bef05@lab.ntt.co.jp \
--to=ogawa.yasufumi@lab.ntt.co.jp \
--cc=ferruh.yigit@intel.com \
--cc=spp@dpdk.org \
--cc=x-fn-spp@sl.ntt-tx.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).