From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ogawa.yasufumi@lab.ntt.co.jp>
Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147])
 by dpdk.org (Postfix) with ESMTP id 535881D491
 for <spp@dpdk.org>; Fri, 15 Jun 2018 05:00:15 +0200 (CEST)
Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153])
 by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w5F30Dnj026903;
 Fri, 15 Jun 2018 12:00:13 +0900
Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1])
 by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id AAF54EA79C9;
 Fri, 15 Jun 2018 12:00:13 +0900 (JST)
Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp
 [129.60.87.134])
 by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id A0683EA78B7;
 Fri, 15 Jun 2018 12:00:13 +0900 (JST)
Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73])
 by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 9C07A4002FE;
 Fri, 15 Jun 2018 12:00:13 +0900 (JST)
References: <1528448512-21000-1-git-send-email-x-fn-spp@sl.ntt-tx.co.jp>
 <201806080901.w5891qj7010253@imss04.silk.ntt-tx.co.jp>
From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Message-ID: <abd9ccd9-f89a-8cad-3776-019db15bef05@lab.ntt.co.jp>
Date: Fri, 15 Jun 2018 11:58:04 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <201806080901.w5891qj7010253@imss04.silk.ntt-tx.co.jp>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-CC-Mail-RelayStamp: 1
To: x-fn-spp@sl.ntt-tx.co.jp, ferruh.yigit@intel.com
Cc: spp@dpdk.org
X-TM-AS-MML: disable
Subject: Re: [spp] [PATCH 2/3] docs: correct incorrect SPP git URL
X-BeenThere: spp@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Soft Patch Panel <spp.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/spp>,
 <mailto:spp-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/spp/>
List-Post: <mailto:spp@dpdk.org>
List-Help: <mailto:spp-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/spp>,
 <mailto:spp-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Jun 2018 03:00:15 -0000

On 2018/06/08 18:01, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> 
> This commit correct incorrect SPP git URL.
> 
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
>   docs/guides/spp_vf/gsg/build.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
> index 93132d4..e7a2a17 100644
> --- a/docs/guides/spp_vf/gsg/build.rst
> +++ b/docs/guides/spp_vf/gsg/build.rst
> @@ -136,8 +136,8 @@ Clone SPP in any directory and compile it.
>   .. code-block:: console
>   
>       $ cd /path/to/spp_home/
I think that users may be confused for what is 'spp_home' and where is it. You should add an explanation about it if you need to 
move to 'spp_home' dir.
> -    $ git clone https://github.com/ntt-ns/Soft-Patch-Panel.git
> -    export SPP_HOME=/path/to/spp_home/Soft-Patch-Panel
> +    $ git clone http://dpdk.org/git/apps/spp
> +    $ export SPP_HOME=/path/to/spp_home/spp
I think it is no good naming because 'spp_home' is not '$SPP_HOME'. Could you change it to be consistent?

Thanks,
>       $ cd $SPP_HOME
>       $ make
>   
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs