Soft Patch Panel
 help / color / Atom feed
From: Yasufumi Ogawa <yasufum.o@gmail.com>
To: x-fn-spp-ml@ntt-tx.co.jp
Cc: spp@dpdk.org
Subject: Re: [spp] [PATCH 5/5] docs: add note regarding NUMA configuration
Date: Mon, 8 Jun 2020 17:21:42 +0900
Message-ID: <ad0a02e9-8321-2532-db3d-7871bb7aad52@gmail.com> (raw)
In-Reply-To: <20200605002854.24054-6-x-fn-spp-ml@ntt-tx.co.jp>

> From: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
> 
> This patch adds new notes for NUMA configuration when starting
> spp_primary.
> 
> This is pointed out by the following DPDK Bugzilla tickets.
> https://bugs.dpdk.org/show_bug.cgi?id=457
> 
> Signed-off-by: Hideyuki Yamashita <yamashita.hideyuki@ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <ntakada14@gmail.com>
> ---
>   docs/guides/gsg/howto_use.rst | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/docs/guides/gsg/howto_use.rst b/docs/guides/gsg/howto_use.rst
> index f182198..4f2e6cd 100644
> --- a/docs/guides/gsg/howto_use.rst
> +++ b/docs/guides/gsg/howto_use.rst
> @@ -422,6 +422,18 @@ if you run the process on single NUMA node.
>      If you use DPDK v18.11 or later, ``--base-virtaddr 0x100000000`` is enabled
>      in default. You need to use this option only for changing the default value.
>   
> +.. note::
> +
> +   ``spp_primary`` tries to create memory pool in the same NUMA node where
> +   it is launched. Under NUMA configuration, the NUMA node where ``spp_primary``
> +   is launched and the NUMA node where NIC is connected can be different
> +   (e.g. spp_primary runs in NUMA node 0 while NIC is connected with NUMA
> +   node 1).
> +   Such configuration may cause performance degradation. In general, under
> +   NUMA configuration, it is best practice to use CPU and NIC which belongs
> +   to the same NUMA node for best performance. So user should align those
> +   when performance degradation makes the situation critical.
> +
I have two comments.

1. Could I confirm WHAT should be configured for avoiding such a 
performance loss?

2. It seems something abruptly considering context of this section 
because you start talking about performance suddenly. If it must be 
considered as a mandatory configuration and should be explained this 
section, I agree your update. On the other hand, what do you think to 
move this note to the next "Performance Optimization" section. I think 
no need to be a note if you move it to the next secion.

Thanks

>   If ``spp_primary`` is launched with two or more lcores, forwarder or monitor
>   is activated. The default is forwarder and monitor is optional in this case.
>   If you use monitor thread, additional option ``--disp-stat`` is required.
> 

  reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-05  0:28 [spp] [PATCH 0/5] updates for catching up DPDK20.02 x-fn-spp-ml
2020-06-05  0:28 ` [spp] [PATCH 1/5] docs: remove unnecessary usage of ethtool x-fn-spp-ml
2020-06-05  0:28 ` [spp] [PATCH 2/5] docs: resolve broken reference link x-fn-spp-ml
2020-06-05  0:28 ` [spp] [PATCH 3/5] docs: catch up updates in dpdk-20.02 x-fn-spp-ml
2020-06-08  8:02   ` Yasufumi Ogawa
2020-06-16  8:28     ` [spp] (x-fn-spp-ml 781) " Hideyuki Yamashita
2020-06-05  0:28 ` [spp] [PATCH 4/5] makefile: change default build target x-fn-spp-ml
2020-06-05  0:28 ` [spp] [PATCH 5/5] docs: add note regarding NUMA configuration x-fn-spp-ml
2020-06-08  8:21   ` Yasufumi Ogawa [this message]
2020-06-16  8:30     ` [spp] (x-fn-spp-ml 783) " Hideyuki Yamashita
2020-06-16 16:18       ` Yasufumi Ogawa
2020-06-18  3:14         ` [spp] (x-fn-spp-ml 796) " Hideyuki Yamashita
2020-06-05  2:40 ` [spp] [PATCH 0/5] updates for catching up DPDK20.02 Itsuro ODA

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ad0a02e9-8321-2532-db3d-7871bb7aad52@gmail.com \
    --to=yasufum.o@gmail.com \
    --cc=spp@dpdk.org \
    --cc=x-fn-spp-ml@ntt-tx.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Soft Patch Panel

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/spp/0 spp/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 spp spp/ http://inbox.dpdk.org/spp \
		spp@dpdk.org
	public-inbox-index spp


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.spp


AGPL code for this site: git clone https://public-inbox.org/ public-inbox