Re: [spp] [RFC] assign global unique port ID

[Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>]

Hi,

To assign port with unique ID, define a struct 'porttype_map' for 
managing a combination of port type and alias of it. I also add a parser 
to convert unique ID to local ID of each of secondaries.

This update is applied to spp_nfv, spp_vm and spp.py which checks if 
user input of unique ID is valid.

Thanks,
Yasufumi

On 2017/10/03 15:34, Yasufumi Ogawa wrote:
> Hi, Gerald, Sy Jong,
> 
> In spp, port ID is assigned as a number incrementally and the number of 
> ID can be different from each sec processes. For instance, ring 0 is 
> added to sec 1 at first while it is added to sec 2 after ring 1, ring 0 
> is referred as port 2 from sec 1 and port 3 from sec 2.
> 
>    spp > sec 1;status
>    ...
>    port id: 0,on,PHY,outport: -99
>    port id: 1,on,PHY,outport: -99
>    port id: 2,on,RING(0),outport: -99  # ring 0 is referred as port 2
> 
>    spp > sec 2;status
>    ...
>    port id: 0,on,PHY,outport: -99
>    port id: 1,on,PHY,outport: -99
>    port id: 2,on,RING(1),outport: -99
>    port id: 3,on,RING(0),outport: -99  # ring 0 is referred as port 3
> 
> User always has to check the status any time patching to avoid mistake. 
> However, it must be annoying and an error is possibly happened.
> 
> I propose to assign global unique ID for port. In this update, port ID 
> is referred as a combination of PMD type and its ID, not a number. For 
> instance,
> 
>    (Before) spp> patch 0 2
>    (After)  spp> patch phy:0 ring:0  # means to patch from phy 0 to ring 0
> 
> If you agree, I would like to send patches for update.
> 
> Thanks,
> Yasufumi
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs