From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id DA28F1B6E0 for ; Mon, 29 Jan 2018 13:45:33 +0100 (CET) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w0TCjWQF022787; Mon, 29 Jan 2018 21:45:32 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id DFE4460294; Mon, 29 Jan 2018 21:45:31 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id CD2C95F680; Mon, 29 Jan 2018 21:45:31 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id AB6D540034B; Mon, 29 Jan 2018 21:45:31 +0900 (JST) From: Yasufumi Ogawa References: <093f4d79-1238-3be8-f242-062bca27a933@lab.ntt.co.jp> Message-ID: Date: Mon, 29 Jan 2018 21:44:20 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <093f4d79-1238-3be8-f242-062bca27a933@lab.ntt.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CC-Mail-RelayStamp: 1 To: spp@dpdk.org, ferruh.yigit@intel.com Cc: srv-apl-arch@lab.ntt.co.jp X-TM-AS-MML: disable Subject: Re: [spp] [RFC] assign global unique port ID X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 12:45:34 -0000 Hi, To assign port with unique ID, define a struct 'porttype_map' for managing a combination of port type and alias of it. I also add a parser to convert unique ID to local ID of each of secondaries. This update is applied to spp_nfv, spp_vm and spp.py which checks if user input of unique ID is valid. Thanks, Yasufumi On 2017/10/03 15:34, Yasufumi Ogawa wrote: > Hi, Gerald, Sy Jong, > > In spp, port ID is assigned as a number incrementally and the number of > ID can be different from each sec processes. For instance, ring 0 is > added to sec 1 at first while it is added to sec 2 after ring 1, ring 0 > is referred as port 2 from sec 1 and port 3 from sec 2. > >   spp > sec 1;status >   ... >   port id: 0,on,PHY,outport: -99 >   port id: 1,on,PHY,outport: -99 >   port id: 2,on,RING(0),outport: -99  # ring 0 is referred as port 2 > >   spp > sec 2;status >   ... >   port id: 0,on,PHY,outport: -99 >   port id: 1,on,PHY,outport: -99 >   port id: 2,on,RING(1),outport: -99 >   port id: 3,on,RING(0),outport: -99  # ring 0 is referred as port 3 > > User always has to check the status any time patching to avoid mistake. > However, it must be annoying and an error is possibly happened. > > I propose to assign global unique ID for port. In this update, port ID > is referred as a combination of PMD type and its ID, not a number. For > instance, > >   (Before) spp> patch 0 2 >   (After)  spp> patch phy:0 ring:0  # means to patch from phy 0 to ring 0 > > If you agree, I would like to send patches for update. > > Thanks, > Yasufumi > -- Yasufumi Ogawa NTT Network Service Systems Labs