From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 85DFB2082 for ; Wed, 7 Nov 2018 04:05:32 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wA735VPa018562; Wed, 7 Nov 2018 12:05:31 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id E3761639AC7; Wed, 7 Nov 2018 12:05:30 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id D8692639A97; Wed, 7 Nov 2018 12:05:30 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id CEFB8400885; Wed, 7 Nov 2018 12:05:30 +0900 (JST) References: <201811061118.wA6BIk7q014743@ccmail04.silk.ntt-tx.co.jp> <201811070036.wA70a07Z025844@ccmail04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Wed, 7 Nov 2018 12:03:17 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201811070036.wA70a07Z025844@ccmail04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Hideyuki Yamashita Cc: spp@dpdk.org, ferruh.yigit@intel.com X-TM-AS-MML: disable Subject: Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2018 03:05:34 -0000 > Hello Yasufumi-san, > > My suggestion is to apply the first patch soon > because without that patch, compile of spp encounters error. > Soon is better. If you compile SPP with DPDK v18.08, yes. > > About replacing deprecaed functions, I am planning to provide patch > after the above mentioned patch applied to master. Could you describe about your patch if you will update to v18.08? I think your patch is for replacing deprecated DPDK's APIs and your patch(es) is applied even if my patch is not applied before (of course, need both of patches for compiling). Anyway, you can send your patch anytime for reviewing. Thanks, > > BR, > Hideyuki Yamashita > NTT TechnoCross > >> Hi Hideyuki, >> >> Could you tell me what is the point of your suggestion? >> >> I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later. >> >> Thanks, >> Yasufumi >> >>> Hello, >>> >>> So far, it looks both patches are not merged into master branch. >>> I think change on makefile is tentative one and no need to merge. >>> But the other change on shared needs to be merged to master >>> because it is essentical change. >>> >>> BR, >>> Hideyuki Yamashita >>> NTT TechnoCross >>> >>>> From: Yasufumi Ogawa >>>> >>>> Compiling SPP with DPDK v18.08 causes some of erros and warnings >>>> because of following reasons. This series of patches is to fix them. >>>> >>>> * Tx queue configuration is not updated for the new Tx offload API. >>>> >>>> * rte_eth_dev_attach/detach is deprecated but still remained. >>>> >>>> Yasufumi Ogawa (2): >>>> shared: remove nouse txq_flags >>>> makefile: ignore deprecated declarations >>>> >>>> src/nfv/Makefile | 1 + >>>> src/shared/common.c | 1 - >>>> src/vf/Makefile | 1 + >>>> src/vm/Makefile | 1 + >>>> 4 files changed, 3 insertions(+), 1 deletion(-) >>>> >>>> -- >>>> 2.7.4