From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id B8CC81DEFD for ; Mon, 11 Jun 2018 03:38:12 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w5B1cAXF003726; Mon, 11 Jun 2018 10:38:10 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id CC69BEA77E1; Mon, 11 Jun 2018 10:38:10 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id C1FFCEA707F; Mon, 11 Jun 2018 10:38:10 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id BBAD940065B; Mon, 11 Jun 2018 10:38:10 +0900 (JST) References: <1528448512-21000-1-git-send-email-x-fn-spp@sl.ntt-tx.co.jp> <201806080901.w5891qlm010254@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Mon, 11 Jun 2018 10:36:43 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201806080901.w5891qlm010254@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 3/3] docs:delete unsupported SPP VF Secondary Command X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 01:38:13 -0000 On 2018/06/08 18:01, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hiroyuki Nakamura > > This commit delete unsupported SPP VF Secondary Command. This patch looks good and has no problems, but subject is not appropriate. Space should be added after 'docs:'. Could you think to change the subject to "docs: delete unsupported SPP VF commands" simply. Thanks > > Signed-off-by: Hiroyuki Nakamura > Signed-off-by: Naoki Takada > --- > docs/guides/spp_vf/commands/secondary.rst | 102 ------------------------------ > 1 file changed, 102 deletions(-) > > diff --git a/docs/guides/spp_vf/commands/secondary.rst b/docs/guides/spp_vf/commands/secondary.rst > index 564e9af..19e594c 100644 > --- a/docs/guides/spp_vf/commands/secondary.rst > +++ b/docs/guides/spp_vf/commands/secondary.rst > @@ -282,105 +282,3 @@ before running ``flush`` command. > .. code-block:: console > > spp > sec 1;cancel > - > - > -add > ---- > - > -Add a PMD to the secondary with resource ID. > - > -Adding ring 0 by > - > -.. code-block:: console > - > - spp> sec 1;add ring 0 > - recv:7:{addring0} > - > -Or adding vhost 0 by > - > -.. code-block:: console > - > - spp> sec 1;add vhost 0 > - recv:7:{addvhost0} > - > - > -patch > ------- > - > -Create a path between two ports, source and destination ports. > -Port ID is referred by status sub commnad. > -This command just creates path and does not start forwarding. > - > -.. code-block:: console > - > - spp > sec 1;patch 0 2 > - recv:7:{patch02} > - > - > -forward > -------- > - > -Start forwarding. > - > -.. code-block:: console > - > - spp > sec 1;forward > - recv:7:{start forwarding} > - > -Running status is changed from ``Idling`` to ``Running`` by > -executing it. > - > -.. code-block:: console > - > - spp > sec 1;status > - recv:7:{Client ID 1 Running > - 1 > - port id: 0,on,PHY,outport: none > - port id: 1,on,PHY,outport: none > - } > - > - > -stop > ----- > - > -Stop forwarding. > - > -.. code-block:: console > - > - spp > sec 1;stop > - recv:7:{start forwarding} > - > -Running status is changed from ``Running`` to ``Idling`` by > -executing it. > - > -.. code-block:: console > - > - spp > sec 1;status > - recv:7:{Client ID 1 Running > - 1 > - port id: 0,on,PHY,outport: none > - port id: 1,on,PHY,outport: none > - } > - > - > -del > ---- > - > -Delete PMD added by ``add`` subcommand from the secondary. > - > -.. code-block:: console > - > - spp> sec 1;del ring 0 > - recv:7:{delring0} > - > - > -exit > ----- > - > -Terminate the secondary. For terminating all secondaries, use ``bye sec`` > -command instead of it. > - > -.. code-block:: console > - > - spp> sec 1;exit > - recv:7:{delring0} >