From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id CDF4C1B73A for ; Thu, 8 Feb 2018 02:22:37 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w181MZI6016089; Thu, 8 Feb 2018 10:22:35 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id B6C8D6386D1; Thu, 8 Feb 2018 10:22:35 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id ABB73637FA2; Thu, 8 Feb 2018 10:22:35 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id A6E694003BC; Thu, 8 Feb 2018 10:22:35 +0900 (JST) References: <4aae78ff-3b6c-cdfe-a8b7-24ec08b73935@lab.ntt.co.jp> <201712280456.vBS4u46q010906@imss03.silk.ntt-tx.co.jp> <9fb4b932-bf15-2e19-b4d7-5cb19694eb9e@intel.com> From: Yasufumi Ogawa Message-ID: Date: Thu, 8 Feb 2018 10:21:21 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <9fb4b932-bf15-2e19-b4d7-5cb19694eb9e@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CC-Mail-RelayStamp: 1 To: Ferruh Yigit , x-fn-spp@sl.ntt-tx.co.jp, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 02/57] spp_vf: support multi process X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 01:22:38 -0000 On 2018/02/08 1:50, Ferruh Yigit wrote: > On 12/28/2017 4:55 AM, x-fn-spp@sl.ntt-tx.co.jp wrote: >> From: Hiroyuki Nakamura >> >> spp_vf was only a single process so far, but spp_vf supported >> multi process. Following modification has been made. >> >> * Change naming machanism to allow hashtable on shared memory >> to be operated by multiple processes. >> * Get config file path from command line argument. >> >> And following modification has been made. >> * Modify comment. >> * Add and modify log message. >> * Add function to remove vhost socket file. >> >> Signed-off-by: Daiki Yamashita >> Signed-off-by: Yasufum Ogawa > > <...> > >> @@ -669,6 +732,24 @@ print_ring_latency_stats() >> #endif /* SPP_RINGLATENCYSTATS_ENABLE */ >> >> /* >> + * VHOST用ソケットファイル削除 >> + */ >> +static void >> +del_vhost_sockfile(struct patch_info *vhost_patchs) >> +{ >> + int cnt; >> + for (cnt = 0; cnt < RTE_MAX_ETHPORTS; cnt++) { >> + if (likely(vhost_patchs[cnt].use_flg == 0)) { >> + /* VHOST未使用はスキップ */ >> + continue; >> + } >> + >> + /* 使用していたVHOSTについて削除を行う */ > > Would you mind translating comments to English. It helps if code understood by > more people. > > <...> > >> } >> + >> + /* Skip dpdk parameters */ >> + argc -= ret_dpdk; >> + argv += ret_dpdk; >> + >> + /* Set log level */ >> + rte_log_set_global_level(RTE_LOG_LEVEL); > > Hi Daiki, Yasufum, > > This breaks the build with dpdk master because RTE_LOG_LEVEL removed in this > release. > > Can you please check this? Hi Ferruh, We have talked how to fix this issue and are preparing a patch for. As you mention before, this is because difference of versions of DPDK, 1711 and 1802. I think we should also update version of SPP, so I send another patch for updating. To clear which of DPDK version for compiling SPP, I will check for it is safely compiled with latest DPDK and update the version immediately in future. Thanks, > > -- Yasufumi Ogawa NTT Network Service Systems Labs