From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 6CF302BE5 for ; Fri, 9 Nov 2018 04:37:01 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wA93b0Qt017411; Fri, 9 Nov 2018 12:37:00 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 34856638483; Fri, 9 Nov 2018 12:37:00 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 28E546380F3; Fri, 9 Nov 2018 12:37:00 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 2453240030D; Fri, 9 Nov 2018 12:37:00 +0900 (JST) References: <201811070507.wA757WWo008866@imss03.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Fri, 9 Nov 2018 12:34:47 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201811070507.wA757WWo008866@imss03.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 0/6] Replace deprecated APIs X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Nov 2018 03:37:02 -0000 On 2018/11/07 14:07, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hideyuki Yamashita > >>>From DPDK-18.08, the follwing APIs become deprecated and > will be deleted in DPDK18.08. > - rte_eth_dev_attach() > - rte_eth_dev_detach() > > For rte_eth_dev_attach(), use of rte_eal_hotplug_add() is recommended. > For rte_eth_dev_detach(), use of rte_eal_hotplug_remove() is recommended. > > To follow the above changes, this patch set provides replacement of > those APIs. Hideyuki, Thank you for suggesting to update to v18.08! Could you re-consider the name of function you added by referring conventions of DPDK and SPP? It has almost no means if just `attach` or `detach`. It is preferable to be self explanatory for how your function works. Commit messages are also required to be revised. Update for the change of function name and modify invalid descriptions for documentation guidelines. Thanks > > Signed-off-by: Hideyuki Yamashita > Signed-off-by: Naoki Takada > > Hideyuki Yamashita (6): > shared: addition of attach() > spp_nfv: replacement of rte_eth_dev_attach() > spp_vf:replacement of rte_eth_dev_attach() > shared: addition of detach() > spp_nfv: replacement of rte_eth_dev_detach() > spp_vm: replacement of rte_eth_dev_detach(). > > src/nfv/nfv.c | 12 ++++----- > src/shared/common.c | 64 +++++++++++++++++++++++++++++++++++++++++++++ > src/shared/common.h | 32 +++++++++++++++++++++++ > src/vf/spp_vf.c | 4 +-- > src/vm/main.c | 2 +- > 5 files changed, 105 insertions(+), 9 deletions(-) > -- Yasufumi Ogawa NTT Network Service Systems Labs