Re: [spp] [PATCH 1/3] docs: add how to install qemu 2.7

[Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>]

On 2018/06/08 18:01, x-fn-spp@sl.ntt-tx.co.jp wrote:
> From: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> 
> This commit adds instruction about how to install qemu 2.7 in case
> user does not have the version of qemu.
Hiroyuki,

Thank you for revising docs for vhost usages. It looks to help user's understanding.

However, some of descriptions are inappropriate for the RST Guidelines.
https://dpdk.org/doc/guides/contributing/documentation.html#rst-guidelines

 > +.. code-block:: console
 > +
 > + $ qemu-system-x86_64 --version
It should be indented at least 3 spaces, and 4 spaces is better for conventional. Could you make sure to use 4 spaces for indenting?

 > +then please install qemu following the instruction of https://wiki.qemu.org/index.php/Hosts/Linux
 > +to install qemu 2.7.
 > +You may need to install libvirt-bin, virtinst, bridge-utils packages via ``apt-get`` install to run ``virt-install``.
 > +
 > +
 >   ``virsh`` is a command line interface that can be used to create, destroy, stop start and edit VMs and configure. After 
create an image file, you can setup it with ``virt-install``.
Line length should be less than 80 chars. First, third and final lines exceed to the limitation.

Thanks,
Yasufumi
> 
> Signed-off-by: Hiroyuki Nakamura <nakamura.hiroyuki@po.ntt-tx.co.jp>
> Signed-off-by: Naoki Takada <takada.naoki@lab.ntt.co.jp>
> ---
>   docs/guides/spp_vf/gsg/build.rst | 14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst
> index 573d6be..93132d4 100644
> --- a/docs/guides/spp_vf/gsg/build.rst
> +++ b/docs/guides/spp_vf/gsg/build.rst
> @@ -37,7 +37,7 @@ Environment
>   -----------
>   
>   * Ubuntu 16.04
> -* qemu-kvm 2.7 or later
> +* qemu-kvm 2.7 or later(if you use vhost reconnect feature described in 3.2.3)
>   * DPDK v17.11 or later
>   
>   
> @@ -165,6 +165,18 @@ Then, bind it with PCI_Number.
>   
>   virsh setup
>   -----------
> +First of all, please check version of qemu-kvm.
> +
> +.. code-block:: console
> +
> + $ qemu-system-x86_64 --version
> +
> +If your system does not have qemu-kvm or the version of qemu is less than 2.7,
> +then please install qemu following the instruction of https://wiki.qemu.org/index.php/Hosts/Linux
> +to install qemu 2.7.
> +You may need to install libvirt-bin, virtinst, bridge-utils packages via ``apt-get`` install to run ``virt-install``.
> +
> +
>   ``virsh`` is a command line interface that can be used to create, destroy, stop start and edit VMs and configure. After create an image file, you can setup it with ``virt-install``.
>   
>   .. code-block:: console
> 


-- 
Yasufumi Ogawa
NTT Network Service Systems Labs