From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id DD0391DF10 for ; Mon, 11 Jun 2018 03:24:05 +0200 (CEST) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w5B1O3A8030855; Mon, 11 Jun 2018 10:24:03 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 6E16763877F; Mon, 11 Jun 2018 10:24:03 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 62C4E638255; Mon, 11 Jun 2018 10:24:03 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 5DCF540075C; Mon, 11 Jun 2018 10:24:03 +0900 (JST) References: <1528448512-21000-1-git-send-email-x-fn-spp@sl.ntt-tx.co.jp> <201806080901.w5891q8H010246@imss04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Mon, 11 Jun 2018 10:22:36 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201806080901.w5891q8H010246@imss04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: x-fn-spp@sl.ntt-tx.co.jp Cc: ferruh.yigit@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 1/3] docs: add how to install qemu 2.7 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2018 01:24:06 -0000 On 2018/06/08 18:01, x-fn-spp@sl.ntt-tx.co.jp wrote: > From: Hiroyuki Nakamura > > This commit adds instruction about how to install qemu 2.7 in case > user does not have the version of qemu. Hiroyuki, Thank you for revising docs for vhost usages. It looks to help user's understanding. However, some of descriptions are inappropriate for the RST Guidelines. https://dpdk.org/doc/guides/contributing/documentation.html#rst-guidelines > +.. code-block:: console > + > + $ qemu-system-x86_64 --version It should be indented at least 3 spaces, and 4 spaces is better for conventional. Could you make sure to use 4 spaces for indenting? > +then please install qemu following the instruction of https://wiki.qemu.org/index.php/Hosts/Linux > +to install qemu 2.7. > +You may need to install libvirt-bin, virtinst, bridge-utils packages via ``apt-get`` install to run ``virt-install``. > + > + > ``virsh`` is a command line interface that can be used to create, destroy, stop start and edit VMs and configure. After create an image file, you can setup it with ``virt-install``. Line length should be less than 80 chars. First, third and final lines exceed to the limitation. Thanks, Yasufumi > > Signed-off-by: Hiroyuki Nakamura > Signed-off-by: Naoki Takada > --- > docs/guides/spp_vf/gsg/build.rst | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) > > diff --git a/docs/guides/spp_vf/gsg/build.rst b/docs/guides/spp_vf/gsg/build.rst > index 573d6be..93132d4 100644 > --- a/docs/guides/spp_vf/gsg/build.rst > +++ b/docs/guides/spp_vf/gsg/build.rst > @@ -37,7 +37,7 @@ Environment > ----------- > > * Ubuntu 16.04 > -* qemu-kvm 2.7 or later > +* qemu-kvm 2.7 or later(if you use vhost reconnect feature described in 3.2.3) > * DPDK v17.11 or later > > > @@ -165,6 +165,18 @@ Then, bind it with PCI_Number. > > virsh setup > ----------- > +First of all, please check version of qemu-kvm. > + > +.. code-block:: console > + > + $ qemu-system-x86_64 --version > + > +If your system does not have qemu-kvm or the version of qemu is less than 2.7, > +then please install qemu following the instruction of https://wiki.qemu.org/index.php/Hosts/Linux > +to install qemu 2.7. > +You may need to install libvirt-bin, virtinst, bridge-utils packages via ``apt-get`` install to run ``virt-install``. > + > + > ``virsh`` is a command line interface that can be used to create, destroy, stop start and edit VMs and configure. After create an image file, you can setup it with ``virt-install``. > > .. code-block:: console > -- Yasufumi Ogawa NTT Network Service Systems Labs