From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 7ECE61D9E for ; Wed, 28 Feb 2018 11:28:32 +0100 (CET) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w1SASUsn028731; Wed, 28 Feb 2018 19:28:30 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id C8F47EA84DC; Wed, 28 Feb 2018 19:28:30 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id BE8B9EA8163; Wed, 28 Feb 2018 19:28:30 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id B230F400728; Wed, 28 Feb 2018 19:28:30 +0900 (JST) References: <1518103091-4624-1-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> <1518103091-4624-2-git-send-email-ogawa.yasufumi@lab.ntt.co.jp> <79cbf414-ecef-8793-b688-d16d9d3cb15a@intel.com> From: Yasufumi Ogawa Message-ID: Date: Wed, 28 Feb 2018 19:27:11 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <79cbf414-ecef-8793-b688-d16d9d3cb15a@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Ferruh Yigit , "spp@dpdk.org" X-TM-AS-MML: disable Subject: Re: [spp] [PATCH 2/2] spp_vf: update to improve usability X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 10:28:33 -0000 On 2018/02/22 20:50, Ferruh Yigit wrote: > On 2/8/2018 3:18 PM, ogawa.yasufumi@lab.ntt.co.jp (ogawa.yasufumi@lab.ntt.co.jp) > wrote: >> From: Yasufumi Ogawa >> >> This update is same as previous patch for spp.py. >> >> * Override emptyline() of Shell class to not repeat previous command. >> >> * Override default() to accept comment line. To find the comment, add >> is_comment_line() which support python and C style comment. >> >> * Remove lower() for user's input to avoid unexpected behaviour. >> >> Signed-off-by: Yasufumi Ogawa > > Hi Yasufumi, > > This is already applied but I am concerned about having two version of python > script, spp.py and spp_vf.py. > > Is there a long term plan for them? > Why we are maintaining two copies and they are slightly differentiated now, as > some features only supported in spp_vf.py? Ferruh, I think I should move spp_vf features to spp.py. We started to develop spp_vf as an experimental project independently, but it is merged SPP repo. As you mentioned, spp_vf.py has features only for spp_vf, however I think it can be moved to spp.py as an extension or plugin to not lose usability. I'd like to consider it. Thanks, Yasufumi > > Does it make sense to merge them? > > Thanks, > ferruh > > -- Yasufumi Ogawa NTT Network Service Systems Labs