From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 85D352BE2 for ; Tue, 6 Nov 2018 13:28:56 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id wA6CSsn1016016; Tue, 6 Nov 2018 21:28:54 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id CD0D5639A7F; Tue, 6 Nov 2018 21:28:54 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id C1B5F639A12; Tue, 6 Nov 2018 21:28:54 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id A92834005EA; Tue, 6 Nov 2018 21:28:54 +0900 (JST) References: <20180823105442.74672-1-ogawa.yasufumi@lab.ntt.co.jp> <201811061118.wA6BIk7q014743@ccmail04.silk.ntt-tx.co.jp> From: Yasufumi Ogawa Message-ID: Date: Tue, 6 Nov 2018 21:26:42 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <201811061118.wA6BIk7q014743@ccmail04.silk.ntt-tx.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CC-Mail-RelayStamp: 1 To: Hideyuki Yamashita Cc: spp@dpdk.org, ferruh.yigit@intel.com X-TM-AS-MML: disable Subject: Re: [spp] [spp 03234] [PATCH 0/2] Fix compile error with DPDK v18.08 X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 12:28:57 -0000 Hi Hideyuki, Could you tell me what is the point of your suggestion? I agreed not to disable warning option in Makefile and need to update for DPDK v18.08 by replacing deprecated functions. I think it is still required to remove deprecated `txq_flags` if update to v18.08. However, I am not sure if you suggest to apply the first patch soon, or it is OK later. Thanks, Yasufumi > Hello, > > So far, it looks both patches are not merged into master branch. > I think change on makefile is tentative one and no need to merge. > But the other change on shared needs to be merged to master > because it is essentical change. > > BR, > Hideyuki Yamashita > NTT TechnoCross > >> From: Yasufumi Ogawa >> >> Compiling SPP with DPDK v18.08 causes some of erros and warnings >> because of following reasons. This series of patches is to fix them. >> >> * Tx queue configuration is not updated for the new Tx offload API. >> >> * rte_eth_dev_attach/detach is deprecated but still remained. >> >> Yasufumi Ogawa (2): >> shared: remove nouse txq_flags >> makefile: ignore deprecated declarations >> >> src/nfv/Makefile | 1 + >> src/shared/common.c | 1 - >> src/vf/Makefile | 1 + >> src/vm/Makefile | 1 + >> 4 files changed, 3 insertions(+), 1 deletion(-) >> >> -- >> 2.7.4